Skip to content

Adding conditional passing of metadata to devices#5297

Open
ram-mac wants to merge 2 commits intoopenconfig:mainfrom
ram-mac:binding_changes
Open

Adding conditional passing of metadata to devices#5297
ram-mac wants to merge 2 commits intoopenconfig:mainfrom
ram-mac:binding_changes

Conversation

@ram-mac
Copy link
Copy Markdown
Contributor

@ram-mac ram-mac commented Apr 3, 2026

Arista devices expect metadata to have username, password even in mTLS scenario.
So, this change modifies GetRequestMetadata to conditionally omit the "password" from the returned metadata when using mTLS with Arista devices.
This change ensures that Arista devices, which extract the username from the certificate in mTLS mode, do not fail due to an unexpected password in the metadata.
The vendor is now passed to PassCred to enable this vendor-specific logic.

@ram-mac ram-mac requested a review from a team as a code owner April 3, 2026 05:38
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a necessary adjustment for Arista device compatibility within the gRPC communication layer. By introducing vendor-aware logic into the credential handling, the system can now conditionally suppress password metadata during mTLS sessions, ensuring that devices relying on certificate-based identity do not reject connections due to extraneous authentication headers.

Highlights

  • Vendor-specific metadata handling: Introduced a vendor field to the creds struct to allow for device-specific logic during gRPC metadata generation.
  • Arista mTLS compatibility: Modified GetRequestMetadata to conditionally omit the password field when communicating with Arista devices over mTLS, preventing authentication failures.
  • Metadata override logic: Refactored the metadata generation to respect existing context values and avoid redundant or conflicting username entries.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 3, 2026

Pull Request Functional Test Report for #5297 / b84c812

No tests identified for validation.

Help

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gRPC credential logic to include vendor-specific handling, specifically for Arista devices. However, the current implementation contains several critical issues, including a compilation error due to an undeclared variable returnMap, typos in field and constant names, and hardcoded vendor logic that hinders multi-vendor support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants