Conversation
Updated README.md to clarify test cases for gNMI union_replace functionality, including idempotent configuration, addition, change, deletion, and movement of configurations.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for gNMI union_replace test cases. It clarifies the testing procedures for various configuration scenarios, ensuring consistent validation of device behavior when applying gNMI operations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5299 / ad793c1Virtual Devices
Hardware Devices
|
Added tests for gNMI union_replace behavior with invalid configurations and overlaps between CLI and OC.
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for the union_replace_test to include a detailed test plan covering idempotent configurations, adding, changing, deleting, and moving configurations, as well as handling hardware mismatches. Feedback was provided to ensure consistent heading formats (gNMI-3.x.y), correct sequential numbering for test steps, and improved clarity in variable naming and test descriptions. Additionally, suggestions were made to remove protocol-specific parameters like the hold-timer from generic interface tests and to fix minor grammatical and capitalization errors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Add test cases for gNMI union_replace Updated README.md to clarify test cases for gNMI union_replace functionality, including idempotent configuration, addition, change, deletion, and movement of configurations. * Expand README with gNMI union_replace test cases Added tests for gNMI union_replace behavior with invalid configurations and overlaps between CLI and OC. * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update feature/gnmi/tests/union_replace_test/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Updated README.md to clarify test cases for gNMI union_replace functionality, including idempotent configuration, addition, change, deletion, and movement of configurations.