Skip to content

Add test cases for gNMI union_replace#5299

Merged
rohit-rp merged 14 commits intomainfrom
dplore-patch-16
Apr 6, 2026
Merged

Add test cases for gNMI union_replace#5299
rohit-rp merged 14 commits intomainfrom
dplore-patch-16

Conversation

@dplore
Copy link
Copy Markdown
Member

@dplore dplore commented Apr 3, 2026

Updated README.md to clarify test cases for gNMI union_replace functionality, including idempotent configuration, addition, change, deletion, and movement of configurations.

Updated README.md to clarify test cases for gNMI union_replace functionality, including idempotent configuration, addition, change, deletion, and movement of configurations.
@dplore dplore requested a review from a team as a code owner April 3, 2026 19:14
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for gNMI union_replace test cases. It clarifies the testing procedures for various configuration scenarios, ensuring consistent validation of device behavior when applying gNMI operations.

Highlights

  • Documentation Update: Updated the README.md file to provide comprehensive test case definitions for gNMI union_replace functionality.
  • Expanded Test Coverage: Added detailed steps for testing idempotent configurations, adding/changing/deleting configurations, and moving configurations between interfaces.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 3, 2026

Pull Request Functional Test Report for #5299 / ad793c1

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
gNMI-3: union_replace
a5d5d188 Log
Cisco 8000E status
gNMI-3: union_replace
9ba1d7c3 Log
Cisco XRd status
gNMI-3: union_replace
00abaeb0 Log
Juniper ncPTX status
gNMI-3: union_replace
6277c1e5 Log
Nokia SR Linux status
gNMI-3: union_replace
95c51d16 Log
Openconfig Lemming status
gNMI-3: union_replace
972f3a43 Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
gNMI-3: union_replace
Cisco 8808 status
gNMI-3: union_replace
Juniper PTX10008 status
gNMI-3: union_replace
Nokia 7250 IXR-10e status
gNMI-3: union_replace

Help

Added tests for gNMI union_replace behavior with invalid configurations and overlaps between CLI and OC.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md for the union_replace_test to include a detailed test plan covering idempotent configurations, adding, changing, deleting, and moving configurations, as well as handling hardware mismatches. Feedback was provided to ensure consistent heading formats (gNMI-3.x.y), correct sequential numbering for test steps, and improved clarity in variable naming and test descriptions. Additionally, suggestions were made to remove protocol-specific parameters like the hold-timer from generic interface tests and to fix minor grammatical and capitalization errors.

dplore and others added 12 commits April 3, 2026 12:34
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rohit-rp rohit-rp merged commit b9f6c9e into main Apr 6, 2026
18 of 19 checks passed
@rohit-rp rohit-rp deleted the dplore-patch-16 branch April 6, 2026 03:20
nsadhasivam pushed a commit to nsadhasivam/featureprofiles that referenced this pull request Apr 6, 2026
* Add test cases  for gNMI union_replace

Updated README.md to clarify test cases for gNMI union_replace functionality, including idempotent configuration, addition, change, deletion, and movement of configurations.

* Expand README with gNMI union_replace test cases

Added tests for gNMI union_replace behavior with invalid configurations and overlaps between CLI and OC.

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update feature/gnmi/tests/union_replace_test/README.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants