Add bulk API support for set operation for route #632
Conversation
| if (mode == SAI_BULK_OP_ERROR_MODE_STOP_ON_ERROR) { | ||
| return overall_status; | ||
| } |
There was a problem hiding this comment.
Why are we doing this special handling? Can we follow the similar method for bulk API handling like done in other APIs? This is auto-generated code, any special handling will make it difficult to maintain
There was a problem hiding this comment.
ok let me fix this
| fib = FIBV4Table | ||
| } | ||
|
|
||
| if req.PacketAction == nil { |
There was a problem hiding this comment.
Are we running into such cases? Is this a valid usecase?
There was a problem hiding this comment.
yes this is needed. There are requests where packetaction was not configured and that's why request failed. This is the reason I have set default to forward action
| fib = FIBV4Table | ||
| } | ||
|
|
||
| entry := fwdconfig.TableEntryAddRequest(r.dataplane.ID(), fib).AppendEntry(fwdconfig.EntryDesc( |
There was a problem hiding this comment.
Why are we creating a new entry? Isn't "SetRouteEntryAttribute" only supposed to update some attributes to a previously created RouteEntry?
3 participants
No description provided.