Add accept action to policy-forwarding supported actions #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robshakir
requested changes
Mar 19, 2025
| @@ -270,6 +276,14 @@ submodule openconfig-pf-forwarding-policies { | |||
| packets that match the rule."; | |||
| } | |||
|
|
|||
| leaf accept { | |||
There was a problem hiding this comment.
What happens when this leaf is set to false? Packets should be dropped?
| leaf accept { | ||
| type boolean; | ||
| default false; | ||
| description |
There was a problem hiding this comment.
I'd like some clarification either in this leaf, or elsewhere, as to how this coexists with ACLs. What is the order of operations -- policy-forwarding and then ACL or ACL then policy-forwarding? Can both be used on a particular link?
dplore
reviewed
Apr 1, 2025
There was a problem hiding this comment.
In routing-policy there are ACCEPT, REJECT and NEXT_STATEMENT results per policy. NEXT_STATEMENT is default. Perhaps we should follow a similar pattern here.
LimeHat
reviewed
Apr 1, 2025
|
@ihebboubaker please do state some operational use cases where the existing model doesn't meet the needs. |
|
/gcbrun |
|
No major YANG version changes in commit 49680ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Scope