-
Notifications
You must be signed in to change notification settings - Fork 667
Add accept action to policy-forwarding supported actions #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add accept action to policy-forwarding supported actions #1269
Conversation
@@ -270,6 +276,14 @@ submodule openconfig-pf-forwarding-policies { | |||
packets that match the rule."; | |||
} | |||
|
|||
leaf accept { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when this leaf is set to false? Packets should be dropped?
leaf accept { | ||
type boolean; | ||
default false; | ||
description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like some clarification either in this leaf, or elsewhere, as to how this coexists with ACLs. What is the order of operations -- policy-forwarding and then ACL or ACL then policy-forwarding? Can both be used on a particular link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In routing-policy there are ACCEPT, REJECT and NEXT_STATEMENT results per policy. NEXT_STATEMENT is default. Perhaps we should follow a similar pattern here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain the use case? It is not clear what is the purpose of the proposed action.
@ihebboubaker please do state some operational use cases where the existing model doesn't meet the needs. |
/gcbrun |
No major YANG version changes in commit 49680ce |
Change Scope