Rename pathz key from name to xpath

[sallylsy]

Change Scope

• Update the key of pathz from name to xpath
• This change is not backwards compatible.

Current Yang tree

module: openconfig-system
  +--rw system
     +--rw oc-sys-grpc:grpc-servers
     |  +--rw oc-sys-grpc:grpc-server* [name]
     |     +--ro oc-gnsi-pathz:gnmi-pathz-policy-counters
     |        +--ro oc-gnsi-pathz:paths
     |           +--ro oc-gnsi-pathz:path* [name]
     |              +--ro oc-gnsi-pathz:name    -> ../state/name
     |              +--ro oc-gnsi-pathz:state
     |                 +--ro oc-gnsi-pathz:name?    string
     |                 +--ro oc-gnsi-pathz:reads
     |                 |  +--ro oc-gnsi-pathz:access-rejects?       oc-yang:counter64
     |                 |  +--ro oc-gnsi-pathz:last-access-reject?   oc-types:timeticks64
     |                 |  +--ro oc-gnsi-pathz:access-accepts?       oc-yang:counter64
     |                 |  +--ro oc-gnsi-pathz:last-access-accept?   oc-types:timeticks64
     |                 +--ro oc-gnsi-pathz:writes
     |                    +--ro oc-gnsi-pathz:access-rejects?       oc-yang:counter64
     |                    +--ro oc-gnsi-pathz:last-access-reject?   oc-types:timeticks64
     |                    +--ro oc-gnsi-pathz:access-accepts?       oc-yang:counter64
     |                    +--ro oc-gnsi-pathz:last-access-accept?   oc-types:timeticks64

Yang tree for this PR

module: openconfig-system
  +--rw system
     +--rw oc-sys-grpc:grpc-servers
     |  +--rw oc-sys-grpc:grpc-server* [name]
     |     +--ro oc-gnsi-pathz:gnmi-pathz-policy-counters
     |        +--ro oc-gnsi-pathz:paths
     |           +--ro oc-gnsi-pathz:path* [xpath]
     |              +--ro oc-gnsi-pathz:xpath    -> ../state/xpath
     |              +--ro oc-gnsi-pathz:state
     |                 +--ro oc-gnsi-pathz:xpath?    string
     |                 +--ro oc-gnsi-pathz:reads
     |                 |  +--ro oc-gnsi-pathz:access-rejects?       oc-yang:counter64
     |                 |  +--ro oc-gnsi-pathz:last-access-reject?   oc-types:timeticks64
     |                 |  +--ro oc-gnsi-pathz:access-accepts?       oc-yang:counter64
     |                 |  +--ro oc-gnsi-pathz:last-access-accept?   oc-types:timeticks64
     |                 +--ro oc-gnsi-pathz:writes
     |                    +--ro oc-gnsi-pathz:access-rejects?       oc-yang:counter64
     |                    +--ro oc-gnsi-pathz:last-access-reject?   oc-types:timeticks64
     |                    +--ro oc-gnsi-pathz:access-accepts?       oc-yang:counter64
     |                    +--ro oc-gnsi-pathz:last-access-accept?   oc-types:timeticks64

[robshakir]

What is the motivation for this change please? Ideally, we're not making backwards-incompatible changes for aesthetic reasons.

[sallylsy]

We want some help from OC team to evaluate the risk on changing the key name.

[robshakir]

ACK -- the risk is that we create a new version of the schema which is incompatible with the same field names, so we now need to flag this.

I know there are some updates in process to this model -- see #1282 -- which I believe are also backwards incompatible.

Could you discuss with @marcushines whether this change could be incorporated there?

[earies]

ACK -- the risk is that we create a new version of the schema which is incompatible with the same field names, so we now need to flag this.

I know there are some updates in process to this model -- see #1282 -- which I believe are also backwards incompatible.

Could you discuss with @marcushines whether this change could be incorporated there?

Agreed - this PR is not necessary and conflicts with the refactoring discussed in #1282

This is no longer going to be a "path" anyways

[sallylsy]

Thanks for the answer. I will close this PR