Update openconfig-wifi-mac.yang

[istout-debug]

Scope Update:

• Initially, this PR introduced 802.11mc Fine Timing Measurement (RTT) as a standalone configuration leaf.
• To better align with OpenConfig style guidelines and to future-proof the schema for additional RTT-related attributes (e.g., burst duration, timers, or thresholds), the model has been refactored.
• RTT configuration and state are now encapsulated in a dedicated rtt container under the ssid list, featuring explicit config and state subcontainers.
• The openconfig-wifi-mac.yang version has been bumped to 1.5.0 to reflect these additions.

Related Issue

Closes #1450

Platform Implementations

• Implementation A: Arista currently supports this via the CLI and through an OpenConfig vendor augment. The goal is to integrate this into the OpenConfig model for long-term support.
• Implementation B: Aruba currently supports this via the CLI. The goal is to integrate this into the OpenConfig model for long-term support.

New Tree View

module: openconfig-wifi-mac
  +--rw ssids
     +--rw ssid* [name]
        +--rw name                 -> ../config/name
        +--rw config
        |  +--rw name?                      string
        |  +--rw enabled?                   boolean
        |  ...
        +--ro state
        |  ...
        +--ro bssids
        |  ...
        +--rw wmm
        |  ...
        +--rw rtt
           +--rw config
           |  +--rw rtt?   boolean
           +--ro state
              +--ro rtt?   boolean

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option to the OpenConfig Wi-Fi MAC model. The primary goal is to provide granular control over the IEEE 802.11mc Fine Timing Measurement (RTT) feature on a per-SSID basis, allowing network administrators to enable or disable precise distance measurement capabilities for associated clients.

Highlights

• New enable-rtt configuration leaf: Added a new boolean leaf, enable-rtt, with a default value of false within the SSID configuration in openconfig-wifi-mac.yang. This leaf enables or disables IEEE 802.11mc Fine Timing Measurement (RTT) for clients associated with the SSID, allowing Access Points to respond to FTM requests for accurate distance measurements.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an enable-rtt leaf to the openconfig-wifi-mac.yang model, which allows configuring IEEE 802.11mc Fine Timing Measurement (RTT) for clients associated with an SSID. The reviewer noted that the new leaf has style and consistency issues, specifically with indentation and the default value for the boolean type not being enclosed in double quotes.

[zpereyo]

/gcbrun

[OpenConfigBot]

No major YANG version changes in commit c703f13

[zpereyo]

/gcbrun

[zpereyo]

/gcbrun

[dplore]

/gcbrun

[jsnyder81]

@istout-debug I notice we don't align with other leaves in SSID.
other features, say broadcast-filter, multicast-filter do not use the word enabled as part of the leaf.

Also, if the plan is to add other features or configuration knobs, should we break this out into it's own container? like say dot11r?

[istout-debug]

@istout-debug I notice we don't align with other leaves in SSID. other features, say broadcast-filter, multicast-filter do not use the word enabled as part of the leaf.

Also, if the plan is to add other features or configuration knobs, should we break this out into it's own container? like say dot11r?

I will update the leaf name to align with other features

I agree that a separate container makes sense for related features. My initial thought was to start with a simple boolean under the SSID, as this is an SSID-level configuration. The plan was to break out more advanced configurations into a dedicated container if vendors provide support for them. However, I'm open to creating a new container and placing the boolean within it. Would this structure it better for future additions?

[istout-debug]

I have made the changes to this PR to reflect what was talked about, if I could please have this reviewed to ensure that this is correct and the workflows dont fail.

[jsnyder81]

I like this approach better given we have ambitions for more configuration knobs.