openconfig macsec sak-rekey-on-live-peer-loss description update

[ishwarbnaik]

Change Scope

• The current description of this leaf is "Rekey on peer loss." . This description should be updated to clearly state that when this leaf is set to "True", a peer loss will trigger a rekey only if the MKA key-server peer still has live peers available. If there are no live peers, the rekey behaviour will depend on the traffic policy ( Add MACSec interface status and MKA security-policy leaf #1430 ).
• Updating the description of openconfig/public/macsec leaf sak-rekey-on-live-peer-loss to take security-policy into account while defining the expected behaviour.
• This change is backward compatible.

Related Issues

Fixes #1446

Platform Implementations

Implementation A: AristaNetworks
When the traffic policy is "traffic unprotected allow active-sak" (Arista), the MACsec KaY will not perform a rekey on live peer loss. Instead, preserves the current SAK, and allows traffic exchange to continue using that SAK when there are no live peers.

mac security
   profile FALLBACK_PROFILE
      key 0abcd... 0 password123
      traffic unprotected allow active-sak
!
interface Ethernet1
   mac security profile FALLBACK_PROFILE

If the policy is traffic unprotected allow or traffic unprotected drop then the traffic will be handled accordingly, when the session fails. No sak rekey required.

Tree View

No changes to tree view

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the clarity of the OpenConfig MACsec model by refining the description of a key configuration leaf. The update ensures that implementers and users have a comprehensive understanding of how the system handles Security Association Key (SAK) rekeying when a peer is lost, particularly in scenarios where no other live peers remain and traffic policies come into play. This change improves the model's accuracy and reduces potential ambiguities in network device configurations.

Highlights

• Clarified MACsec SAK Rekey Behavior: The description for the sak-rekey-on-live-peer-loss leaf in the openconfig-macsec.yang model has been updated to provide a more precise explanation of its behavior. It now explicitly states that rekeying on peer loss occurs only if other live peers exist, and if not, the behavior is determined by the configured traffic policy.
• Added New Revision Entry: A new revision entry (2026-03-24) has been added to the openconfig-macsec.yang module to document this description update.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the openconfig-macsec.yang model by adding a new revision 2026-03-24 (version 1.2.1) and expanding the description for the sak-rekey-on-live-peer-loss leaf. An indentation issue was also corrected. Feedback includes updating the oc-ext:openconfig-version to 1.2.1 for consistency and changing the spelling of 'behaviour' to 'behavior'.

[dplore]

/gcbrun

[OpenConfigBot]

No major YANG version changes in commit 0aef5d5