Add path for optics error counters#1459
Open
sallylsy wants to merge 1 commit intoopenconfig:masterfrom
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds several lane-specific metrics to the OpenConfig platform transceiver model, including fault counters, loss of signal/lock counters, and signal-to-noise ratio (SNR) measurements for both host and media sides. The review feedback identifies indentation errors and notes that host-side metrics were incorrectly placed within a media-side grouping, suggesting they be moved to the appropriate host-lane-state grouping.
7b0495a to
a767d80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Scope
Platform Implementations
Tree View
module: openconfig-platform +--rw components +--rw component* [name] +--rw oc-transceiver:transceiver | +--rw oc-transceiver:physical-channels | | +--rw oc-transceiver:channel* [index] | | +--ro oc-transceiver:state | | +--ro oc-transceiver:index? uint16 | | +--ro oc-transceiver:associated-optical-channel? -> /oc-platform:components/component/name | | +--ro oc-transceiver:description? string | | +--ro oc-transceiver:tx-laser? boolean | | +--ro oc-transceiver:target-output-power? decimal64 | | +--ro oc-transceiver:laser-age? oc-types:percentage | | +--ro oc-transceiver:laser-temperature | | | +--ro oc-transceiver:instant? decimal64 | | | +--ro oc-transceiver:avg? decimal64 | | | +--ro oc-transceiver:min? decimal64 | | | +--ro oc-transceiver:max? decimal64 | | | +--ro oc-transceiver:interval? oc-types:stat-interval | | | +--ro oc-transceiver:min-time? oc-types:timeticks64 | | | +--ro oc-transceiver:max-time? oc-types:timeticks64 | | +--ro oc-transceiver:target-frequency-deviation | | | +--ro oc-transceiver:instant? decimal64 | | | +--ro oc-transceiver:avg? decimal64 | | | +--ro oc-transceiver:min? decimal64 | | | +--ro oc-transceiver:max? decimal64 | | | +--ro oc-transceiver:interval? oc-types:stat-interval | | | +--ro oc-transceiver:min-time? oc-types:timeticks64 | | | +--ro oc-transceiver:max-time? oc-types:timeticks64 | | +--ro oc-transceiver:tec-current | | | +--ro oc-transceiver:instant? decimal64 | | | +--ro oc-transceiver:avg? decimal64 | | | +--ro oc-transceiver:min? decimal64 | | | +--ro oc-transceiver:max? decimal64 | | | +--ro oc-transceiver:interval? oc-types:stat-interval | | | +--ro oc-transceiver:min-time? oc-types:timeticks64 | | | +--ro oc-transceiver:max-time? oc-types:timeticks64 | | +--ro oc-transceiver:tx-failure? boolean | | +--ro oc-transceiver:rx-los? boolean | | +--ro oc-transceiver:rx-cdr-lol? boolean + | | +--ro oc-transceiver:tx-fault-count? oc-yang:counter64 + | | +--ro oc-transceiver:tx-los-count? oc-yang:counter64 + | | +--ro oc-transceiver:tx-lol-count? oc-yang:counter64 + | | +--ro oc-transceiver:rx-los-count? oc-yang:counter64 + | | +--ro oc-transceiver:rx-lol-count? oc-yang:counter64 + | | +--ro oc-transceiver:host-snr? decimal64 + | | +--ro oc-transceiver:media-snr? decimal64