Skip to content

Add fields to IR and IROptions used by settting the path origin from the YANG module name or a specified name. #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 28, 2025
Merged

Add fields to IR and IROptions used by settting the path origin from the YANG module name or a specified name. #1030

merged 9 commits into from
May 28, 2025

Conversation

keogaki
Copy link
Contributor

@keogaki keogaki commented Apr 15, 2025

@keogaki
Add fields to IR and IROptions structs to support ygnmi/generator com…
99b8043 
…mand option to set the path origin from the YANG module name or an arbitrarily specified name.
@coveralls
Copy link

coveralls commented Apr 15, 2025 •
edited
Loading

Coverage Status

coverage: 88.813% (+0.005%) from 88.808%
when pulling 8b9ad6e on keogaki:set_path_origin
into 863d894 on openconfig:master.

@keogaki keogaki changed the title Add fields to IR and IROptions used by settting the path origin from the YANG module name or an specified name. Add fields to IR and IROptions used by settting the path origin from the YANG module name or a specified name. Apr 15, 2025
robshakir
robshakir requested changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution -- but this doesn't look like the right design to me. We're adding things to the ygot-generated IR that are not really in-line with what the IR should be specifying -- i.e., pre-parsed details of YANG structures that code-generation can use.

robshakir
robshakir reviewed Apr 16, 2025
View reviewed changes
@keogaki keogaki requested a review from robshakir April 16, 2025 01:54
@keogaki keogaki mentioned this pull request Apr 16, 2025
Merged
@keogaki keogaki marked this pull request as ready for review April 23, 2025 08:33
robshakir
robshakir reviewed May 23, 2025
View reviewed changes
Copy link
Contributor

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. This looks better now that it is encapsulated in the IR generation. I have one suggested logic change, and then some style changes.

robshakir
robshakir approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@robshakir
Copy link
Contributor

/gcbrun

@robshakir robshakir merged commit 3a953aa into openconfig:master May 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplore dplore dplore left review comments

@robshakir robshakir robshakir approved these changes

Assignees

@DanG100 DanG100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keogaki @coveralls @robshakir @dplore @DanG100