Deprecate ImageID - #1336
Draft
sudo-bmitch wants to merge 1 commit into
Draft
Conversation
sudo-bmitch
requested review from
cyphar,
jonjohnsonjr,
sajayantony,
stevvooe and
tianon
as code owners
August 20, 2026 20:38
AkihiroSuda
reviewed
Aug 20, 2026
|
|
||
| NOTE: Do not confuse DiffIDs with [layer digests](manifest.md#image-manifest-property-descriptions), often referenced in the manifest, which are digests over compressed or uncompressed content. | ||
|
|
||
| ### Layer ChainID |
Member
There was a problem hiding this comment.
https://github.com/opencontainers/image-spec/blob/main/identity/chainid.go should be deprecated in v1.2 and removed in v1.3-ish
Contributor
Author
There was a problem hiding this comment.
Good catch. I'll revert this to a deprecation, and add a similar deprecation to the Go code.
sudo-bmitch
marked this pull request as draft
August 20, 2026 21:00
tianon
previously approved these changes
Aug 21, 2026
Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
force-pushed
the
pr-image-id
branch
from
August 21, 2026 14:24
a613c9a to
e0cbf53
Compare
Contributor
Author
|
On a second viewing, ChainID is used by a lot of runtime tools, so I'm going to leave that. https://pkg.go.dev/github.com/opencontainers/image-spec@v1.1.1/identity?tab=importedby |
sudo-bmitch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1333