Skip to content

build: use POSIX regex in libpathrs build#5194

Merged
cyphar merged 1 commit intoopencontainers:mainfrom
akhilerm:fix-libpathrs-build
Mar 24, 2026
Merged

build: use POSIX regex in libpathrs build#5194
cyphar merged 1 commit intoopencontainers:mainfrom
akhilerm:fix-libpathrs-build

Conversation

@akhilerm
Copy link
Contributor

word boundary anchor \> is present only in GNU awk implementation. This will not work if we are building libpathrs inside a container like debian/ubuntu which uses mawk. Therefore switch to a POSIX compatible regex that can be used with all implementations of awk to find the system libc path

@akhilerm
Copy link
Contributor Author

cc: @cyphar

@cyphar cyphar added this to the 1.5.0-rc.2 milestone Mar 24, 2026
@cyphar cyphar added the backport/1.5-todo A PR in main branch which needs to be backported to release-1.5 label Mar 24, 2026
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is fine to me

@cyphar cyphar force-pushed the fix-libpathrs-build branch from a455873 to af48a50 Compare March 24, 2026 10:20
word boundary anchor \> is present only in GNU awk implementation. This
will not work if we are building libpathrs inside a container like
debian/ubuntu which uses mawk. Therefore switch to a POSIX compatible
regex that can be used with all implementations of awk to find the
system libc path

Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
Signed-off-by: Aleksa Sarai <aleksa@amutable.com>
@cyphar cyphar force-pushed the fix-libpathrs-build branch from af48a50 to 28d5ffb Compare March 24, 2026 10:20
Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@cyphar cyphar merged commit 142c838 into opencontainers:main Mar 24, 2026
63 checks passed
@cyphar cyphar added backport/1.5-done A PR in main branch which has been backported to release-1.5 and removed backport/1.5-todo A PR in main branch which needs to be backported to release-1.5 labels Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.5-done A PR in main branch which has been backported to release-1.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants