Skip to content

Harden password reset email delivery feedback#14

Merged
leoisadev1 merged 1 commit into
mainfrom
fix-password-reset-email-delivery
May 27, 2026
Merged

Harden password reset email delivery feedback#14
leoisadev1 merged 1 commit into
mainfrom
fix-password-reset-email-delivery

Conversation

@leoisadev1

@leoisadev1 leoisadev1 commented May 27, 2026

Copy link
Copy Markdown
Member

Summary

  • stop the password reset form from echoing the submitted email or claiming delivery
  • log Resend accepted/rejected outcomes with purpose and domains, without secrets/full addresses
  • restore hard failures for missing transactional email config and tag notification delivery emails

Verification

  • bun test scripts/auth-email.test.ts
  • bun run lint
  • bun run check-types
  • bun run build

Production finding

  • Convex production logs show Resend rejected the reset email because amend.sh is not verified in Resend
  • current DNS does not expose Resend records for amend.sh; domain verification still needs to be completed in Resend/Vercel DNS for real delivery

Summary by cubic

Hardened the password reset flow to avoid leaking email addresses or implying delivery. Added strict config checks and provider outcome logging to improve security and observability.

  • Bug Fixes
    • UI no longer echoes the submitted email; shows “Reset requested” with generic guidance.
    • Transactional email now throws if RESEND_API_KEY or EMAIL_FROM is missing.
    • Logs provider accepted/rejected outcomes with purpose and sender/recipient domains (no secrets).
    • Tags emails with purpose (password_reset, notification_delivery) for clearer logs.
    • Added tests to verify UI copy and logging markers.

Written for commit b71709c. Summary will update on new commits. Review in cubic

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@leoisadev1, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 382e70c1-65aa-471a-b2b2-a5aa047a0b32

📥 Commits

Reviewing files that changed from the base of the PR and between da84fba and b71709c.

📒 Files selected for processing (4)
  • apps/web/src/components/sign-in-form.tsx
  • packages/backend/convex/amendTransactionalEmails.ts
  • packages/backend/convex/httpRuntimeDeliveries.ts
  • scripts/auth-email.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@leoisadev1 leoisadev1 merged commit 8e28a92 into main May 27, 2026
6 of 7 checks passed
@leoisadev1 leoisadev1 deleted the fix-password-reset-email-delivery branch May 27, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant