Create print button #10507

bvenceslas · 2025-09-18T13:25:01Z

Description

This PR is made to create a Print Button that will facilitate Madagascar to print the certificate in offline mode.
The print button will be used on the review page.

country confid PR

Issues

[Issue #10039 ]
Issue #10102

Checklist

I have linked the correct Github issue under "Development"
I have tested the changes locally, and written appropriate tests
I have tested beyond the happy path (e.g. edge cases, failure paths)
I have updated the changelog with this change (if applicable)
I have updated the GitHub issue status accordingly

# Conflicts: # packages/client/src/v2-events/components/forms/File.interaction.stories.tsx # packages/client/src/v2-events/components/forms/FormFieldGenerator/FormSectionComponent.tsx

cibelius

All the PR check failures need to be fixed, will review again after that is done

…s-core into ocrvs-10039-new

packages/commons/src/conditionals/conditionals.test.ts

packages/commons/src/conditionals/conditionals.ts

packages/commons/src/conditionals/validate.ts

packages/migration/src/migrations/events/1746712582483_create_events_and_actions_tables.sql

…r drafts

pankaj-pant · 2025-10-02T19:30:58Z

packages/client/src/v2-events/hooks/usePrintableCertificate.ts

+    ? findActiveDraftForEvent(event, remoteDraft)
+    : undefined
+
+  const emptyDraft = createEmptyDraft(event.id, createTemporaryId(), 'DECLARE')


need further clarification about which actionTypes can be passed here

pankaj-pant · 2025-10-03T14:48:46Z

packages/client/src/utils/referenceApi.ts

    throw Error(res.statusText)
  }
-  const response = await res.json()
+  const response: IApplicationConfigResponse = await res.json()


these changes are failing storybook stories locally and in CI

I made the default HTTP handlers in Storybook now return a 8 byte string as the "font". Previously it seemed like our http handlers were internally making requests to country config to fetch the fonts. Not sure how it ever worked as CI certainly doens't have country config running

pankaj-pant · 2025-10-03T17:38:18Z

packages/client/.storybook/default-request-handlers.ts

      return HttpResponse.arrayBuffer(fontArrayBuffer)
    }),

+    http.get('/api/countryconfig/fonts/NotoSans-Bold.ttf', async () => {


storybook interactions passing locally now, but still failing when snapshots are being taken a tad early, do we need to introduce a delay in the snapshot?

…isation isn't slown down

cursor

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

cursor · 2025-10-03T19:29:11Z

packages/client/src/v2-events/features/events/actions/print-certificate/pdfUtils.ts

+      // If even one of the parts is undefined or null, then return empty string
      const idParts = args.slice(0, -1)
-      if (idParts.some((part) => part === undefined)) {
+      if (idParts.some((part) => !isNil(part))) {


Bug: Intl Helper Condition Inverted

The $intl Handlebars helper's condition if (idParts.some((part) => !isNil(part))) is inverted. It currently returns an empty string when all idParts are defined, rather than when any part is null or undefined, leading to incorrect translation ID processing.

@pankaj-pant note this. I changed it to isNil(part)

…s tennis club membership cert expects there to be a PRINT_CERTIFICATE action

cursor · 2025-10-03T20:03:25Z

packages/client/src/v2-events/features/events/actions/print-certificate/pdfUtils.ts

+      // If even one of the parts is undefined or null, then return empty string
      const idParts = args.slice(0, -1)
-      if (idParts.some((part) => part === undefined)) {
+      if (idParts.some((part) => !isNil(part))) {


Bug: Intl Helper Returns Incorrectly

The $intl Handlebars helper in pdfUtils.ts has an inverted condition. It currently returns an empty string when all idParts are defined, rather than when any part is null or undefined as intended.

cursor · 2025-10-03T20:13:28Z

packages/client/src/v2-events/features/events/registered-fields/AlphaPrintButton.tsx

+        createdBySignature: userDetails.localRegistrar?.signature,
+        createdAtLocation: userDetails.primaryOffice.id as UUID
+      }
+    ]


Bug: Invalid Action Type Causes Runtime Errors

The AlphaPrintButton component creates an optimistic action with DECLARATION_ACTION_UPDATE as its type. This string constant is not a valid ActionType enum value, causing type mismatches and runtime errors when the action is processed or used in an EventDocument.

cursor · 2025-10-03T20:13:28Z

packages/client/src/tests/test-data-generators.ts

        mobile: '+260911111111',
        email: '[email protected]',
        role: {
+          id: TestUserRole.Enum.SOCIAL_WORKER,


Bug: Role ID and Label Mismatch Causes Authorization Issues

The fieldAgent user's role ID is set to TestUserRole.Enum.SOCIAL_WORKER, but its label remains 'Hospital Clerk'. This mismatch between the role ID and its displayed name could lead to incorrect authorization or confusing behavior.

…ing there is nothing when app inits

rikukissa · 2025-10-04T06:27:39Z

E2Es passing here @bvenceslas @pankaj-pant https://github.com/opencrvs/e2e/actions/runs/18240400113

All change requests resolved, and tests passing in CI and in e2e

bvenceslas and others added 3 commits September 10, 2025 18:32

WIP: create print button for offline certificate printing

19bcede

test hasRole with a mockUser

788f451

Merge remote-tracking branch 'origin/develop' into ocrvs-10039-new

80a78fa

# Conflicts: # packages/client/src/v2-events/components/forms/File.interaction.stories.tsx # packages/client/src/v2-events/components/forms/FormFieldGenerator/FormSectionComponent.tsx

This comment has been minimized.

Sign in to view

cibelius and others added 4 commits September 18, 2025 16:30

remove .wireit file

d9547bf

merge develop to printbutton component

58d124f

disable print button after first certificate print

29a3bef

fix the SignatureField stories test

0371ee9

bvenceslas marked this pull request as ready for review September 25, 2025 13:46

add role id to data generator

2a73a5d

bvenceslas requested review from Zangetsu101, cibelius and makelicious September 25, 2025 14:52

bvenceslas added 3 commits September 25, 2025 17:18

fix the print button stories

fdf531e

add license to PrintButton file

b678fa8

refactor the printButton stories, remove unecessry code from warnings

59f2b93

cibelius previously requested changes Sep 26, 2025

View reviewed changes

Merge branch 'develop' into ocrvs-10039-new

fcf8930

bvenceslas changed the title ~~WIP: Create print button — add hasRole feature~~ Create print button — add hasRole feature Sep 29, 2025

bvenceslas added 3 commits September 29, 2025 11:15

fix bad code within 1746712582483_create_events_and_actions_tables.sql

f2acb00

Merge branch 'ocrvs-10039-new' of https://github.com/opencrvs/opencrv…

596eea1

…s-core into ocrvs-10039-new

Merge branch 'develop' into ocrvs-10039-new

6d745e6

euanmillar linked an issue Sep 29, 2025 that may be closed by this pull request

As a system admin, I need to be able to configure a print button in any page of the form that can print one of the certified copy templates #10039

Open

5 tasks

bvenceslas added 2 commits September 29, 2025 13:54

fix the accept and the file interaction storybook test

c5a8e91

Merge branch 'ocrvs-10039-new' of https://github.com/opencrvs/opencrv…

115e037

…s-core into ocrvs-10039-new

cibelius reviewed Sep 29, 2025

View reviewed changes

packages/commons/src/conditionals/conditionals.test.ts Outdated Show resolved Hide resolved

cibelius reviewed Sep 29, 2025

View reviewed changes

packages/commons/src/conditionals/conditionals.ts Show resolved Hide resolved

cibelius reviewed Sep 29, 2025

View reviewed changes

packages/commons/src/conditionals/validate.ts Outdated Show resolved Hide resolved

cibelius reviewed Sep 29, 2025

View reviewed changes

packages/migration/src/migrations/events/1746712582483_create_events_and_actions_tables.sql Show resolved Hide resolved

fix PrintButton stories test

c5e5971

bvenceslas and others added 4 commits October 2, 2025 15:22

Merge branch 'develop' into ocrvs-10039-new

2f19c11

use TestUserRole

6aae487

address pr comments related to usePrintableCertificate hook

2c16529

make sure address component only emits expected form config values fo…

e142395

…r drafts

pankaj-pant reviewed Oct 2, 2025

View reviewed changes

pankaj-pant added 3 commits October 3, 2025 17:14

cache certificate font files on app load for offline printing

ac09843

move optimistic print action one layer up

c9bb776

Merge branch 'develop' into ocrvs-10039-new

c6f92da

pankaj-pant reviewed Oct 3, 2025

View reviewed changes

fix font issue in storybook

c0cc3eb

pankaj-pant reviewed Oct 3, 2025

View reviewed changes

in storybook, just use a 8 byte array as a 'font' so that app initial…

461af36

…isation isn't slown down

cursor bot reviewed Oct 3, 2025

View reviewed changes

use a different certificate template for demonstrating print button a…

bf58e4d

…s tennis club membership cert expects there to be a PRINT_CERTIFICATE action

cursor bot reviewed Oct 3, 2025

View reviewed changes

rikukissa added 2 commits October 3, 2025 23:09

fix logical bug in helper

a910be8

remove UPDATE from commons

fe76e35

cursor bot reviewed Oct 3, 2025

View reviewed changes

rikukissa approved these changes Oct 3, 2025

View reviewed changes

rikukissa added 2 commits October 3, 2025 23:34

fix test that was asserting against all files in browser cache, assum…

a812d42

…ing there is nothing when app inits

add fonts src to csp

ec20129

opencrvs deleted a comment from cursor bot Oct 4, 2025

rikukissa added 👌 LGTM and removed 💅 Waiting For Review labels Oct 4, 2025

pankaj-pant merged commit 7b299f3 into develop Oct 4, 2025
163 of 165 checks passed

bvenceslas deleted the ocrvs-10039-new branch October 20, 2025 09:47

Create print button #10507

Create print button #10507

Uh oh!

Conversation

bvenceslas commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Checklist

Uh oh!

This comment has been minimized.

cibelius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pankaj-pant Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

pankaj-pant Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

rikukissa Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

pankaj-pant Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

This PR is being reviewed by Cursor Bugbot

Uh oh!

cursor bot Oct 3, 2025

Choose a reason for hiding this comment

Bug: Intl Helper Condition Inverted

Uh oh!

rikukissa Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Oct 3, 2025

Choose a reason for hiding this comment

Bug: Intl Helper Returns Incorrectly

Uh oh!

cursor bot Oct 3, 2025

Choose a reason for hiding this comment

Bug: Invalid Action Type Causes Runtime Errors

Uh oh!

cursor bot Oct 3, 2025

Choose a reason for hiding this comment

Bug: Role ID and Label Mismatch Causes Authorization Issues

Uh oh!

rikukissa commented Oct 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bvenceslas commented Sep 18, 2025 •

edited

Loading