feat: v2 id reader #10557
Merged
feat: v2 id reader #10557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
…nto v2-id-reader
…e into v2-id-reader
naftis
reviewed
Oct 16, 2025
packages/client/src/v2-events/components/forms/FormFieldGenerator/FormSectionComponent.tsx
Show resolved
Hide resolved
naftis
reviewed
Oct 16, 2025
packages/client/src/v2-events/components/forms/FormFieldGenerator/GeneratedInputField.tsx
Outdated
Show resolved
Hide resolved
naftis
reviewed
Oct 16, 2025
packages/client/src/v2-events/features/events/registered-fields/QrReader.tsx
Outdated
Show resolved
Hide resolved
naftis
approved these changes
Oct 16, 2025
Member
There was a problem hiding this comment.
LGTM. The FormSectionComponent has regression potential with the child-parent functionality but the Storybook interaction tests should mitigate that. Also the validation feature needs to be built but I'd focus on delivering the current functionality as the QR scanner isn't used by countries yet.
Contributor
|
Your environment is deployed to https://v2-id-reader.e2e-k8s.opencrvs.dev |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Country configuration: opencrvs/opencrvs-countryconfig#1102