Skip to content

Conversation

@rikukissa
Copy link
Member

@rikukissa rikukissa commented Sep 25, 2025

Description

opencrvs/opencrvs-countryconfig#1043
opencrvs/e2e#105

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@rikukissa
Copy link
Member Author

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


Copy link
Contributor

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any benefit in reindexing after seed? I mean the events db is empty so what are we indexing?
Or does it initialize the indexes? In that case should the ensureIndexExists be removed from the events service?

@cursor

This comment was marked as spam.

@rikukissa
Copy link
Member Author

Is there any benefit in reindexing after seed? I mean the events db is empty so what are we indexing? Or does it initialize the indexes? In that case should the ensureIndexExists be removed from the events service?

There might not be any benefit unless seeding would write records one day. Or if we want a hook for country config to sync locations for instance to analytics database?

@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-10558.opencrvs.dev

@jamil314 jamil314 merged commit cc4fa91 into develop Oct 9, 2025
156 of 161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants