-
Notifications
You must be signed in to change notification settings - Fork 92
[OCRVS-10558] Fix reindexing output #10575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
Zangetsu101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any benefit in reindexing after seed? I mean the events db is empty so what are we indexing?
Or does it initialize the indexes? In that case should the ensureIndexExists be removed from the events service?
This comment was marked as spam.
This comment was marked as spam.
There might not be any benefit unless seeding would write records one day. Or if we want a hook for country config to sync locations for instance to analytics database? |
|
Your environment is deployed to https://ocrvs-10558.opencrvs.dev |
Description
opencrvs/opencrvs-countryconfig#1043
opencrvs/e2e#105
Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.
Link this pull request to the GitHub issue (and optionally name the branch
ocrvs-<issue #>)Checklist