Skip to content

Conversation

@cibelius
Copy link
Contributor

@cibelius cibelius commented Sep 26, 2025

Description

E2e tests: opencrvs/opencrvs-farajaland#1717
Cc PR: opencrvs/opencrvs-countryconfig#1048

There were basically two different bugs:

  1. Values of hidden fields were affecting conditionals of other fields
  • This is fixed by the change in packages/client/src/v2 events/components/forms/FormFieldGenerator/FormSectionComponent.tsx
  1. The omitting of hidden fields was not working correctly, as the omitHiddenFields() might not actually omit all hidden fields
  • This is fixed by the recursive function in omitHiddenFields()

This PR resolves #10578 and also other bugs on e.g. correction form flow.

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-10578.opencrvs.dev

@cibelius cibelius changed the title progress Fix field conditionality breaking Oct 1, 2025
@cibelius cibelius marked this pull request as ready for review October 1, 2025 06:34
@cibelius cibelius changed the title Fix field conditionality breaking Fix bug with field conditionals being affected by values of hidden fields Oct 1, 2025
@cibelius cibelius merged commit 9e546f5 into develop Oct 1, 2025
84 checks passed
@cibelius cibelius deleted the ocrvs-10578 branch October 1, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants