Fix bugs on 'Certified' action modal #10638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
cibelius
changed the title
cibelius
commented
Oct 7, 2025
| eventConfig={eventConfig} | ||
| fields={page.fields} | ||
| id="locationForm" | ||
| id="pagesSection" |
Contributor
Author
There was a problem hiding this comment.
Unrelated change just for better id.
cibelius
commented
Oct 7, 2025
| }) => { | ||
| const { setAllTouchedFields, touchedFields: initialTouchedFields } = | ||
| useEventFormData() | ||
| const { setAllTouchedFields, touchedFields } = useEventFormData() |
Contributor
Author
There was a problem hiding this comment.
Unrelated change, no need to rename value.
makelicious
reviewed
Oct 7, 2025
...ues/EventOverview/components/EventHistory/EventHistoryDialog/components/PrintCertificate.tsx
Show resolved
Hide resolved
makelicious
reviewed
Oct 7, 2025
makelicious
reviewed
Oct 8, 2025
makelicious
approved these changes
Oct 8, 2025
Contributor
Author
|
Tests passed here: https://github.com/opencrvs/e2e/actions/runs/18345477566 Failing storybook test is not related to this PR, see this discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves: #10583
CC: opencrvs/opencrvs-countryconfig#1066
E2e tests: opencrvs/opencrvs-farajaland#1739
Bug 3 was spinned off to its own issue due to being surprisingly complex: #10654
isEmptyValue()check to modal row filter. This fixes bug 1.required: trueto the generated verification page field to display 'No' value. This fixes Bug 2._in field ids, as they could cause issues with out Formik transformations. This fixes Bug 4.Checklist