Skip to content

Conversation

@cibelius
Copy link
Contributor

@cibelius cibelius commented Oct 9, 2025

Description

We want to display details from FieldType.DATA on the 'Certified' action audit modal

Resolves: #10654
CC PR: opencrvs/opencrvs-countryconfig#1082
E2e tests: opencrvs/opencrvs-farajaland#1749

  • Save FieldType.DATA details to db as part of action, so that they can be displayed later
  • Add Output to FieldType.DATA component

Misc.

  • Remove unused setFieldValue from <FormSectionComponent/>
  • Flip showPreviouslyMissingValuesAsChanged prop default value on <Output/> component
Screenshot 2025-10-14 at 9 34 20

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@cibelius cibelius changed the title progress with allowing value to data field Save FieldType.DATA values to db as part of action, introduce `ConditionalType.DISPLAY_ON_AUDIT_DETAILS Oct 13, 2025
@cibelius cibelius changed the title Save FieldType.DATA values to db as part of action, introduce `ConditionalType.DISPLAY_ON_AUDIT_DETAILS Save FieldType.DATA values to db as part of action, introduce ConditionalType.DISPLAY_ON_AUDIT_DETAILS Oct 13, 2025
@cibelius cibelius marked this pull request as ready for review October 13, 2025 13:19
@cibelius cibelius changed the title Save FieldType.DATA values to db as part of action, introduce ConditionalType.DISPLAY_ON_AUDIT_DETAILS Save FieldType.DATA values to db as part of action, add Output for FieldType.DATA Oct 13, 2025
@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-10654.opencrvs.dev

Copy link
Contributor

@jamil314 jamil314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

value,
previousValue,
showPreviouslyMissingValuesAsChanged = true,
showPreviouslyMissingValuesAsChanged = false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-10654.e2e-k8s.opencrvs.dev

@cibelius cibelius merged commit 6275bdd into develop Oct 16, 2025
156 of 158 checks passed
@cibelius cibelius deleted the ocrvs-10654 branch October 16, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Payment details not appearing in 'Certified' action modal

4 participants