Skip to content

Conversation

@cibelius
Copy link
Contributor

@cibelius cibelius commented Oct 29, 2025

Description

Resolves: #10824

Farajaland PR: opencrvs/opencrvs-farajaland#1796
CC PR: opencrvs/opencrvs-countryconfig#1124

  • Implement new event overview UI, which is separated in to three tabs: event summary, 'Record' and 'Audit'
    • Each tab has its own url path
    • Remove ActionType.READ aka 'View' action from the action menu options
  • Add new concept of "quick action", which is an action that is executed 'on the spot' via a simple modal, instead of an action flow. Events which are executed via quick action are:
    • Validation (when validating a declared record)
    • Registration (when registering a declared record)
    • Archival
    • Rejection (Does not use quick action modal, since it has custom logic. Instead uses the existing rejection modal)
  • This means we can remove the old validation and registering action Pages.tsx and Review.tsx. Why:
    • If user is validating/registering a notified event, it will happen with the declare flow in /client/src/v2-events/features/events/actions/declare/index.tsx
    • If user is validating/registering a declared event, it will happen with the new quick action modal
  • Allow rejecting a record waiting for validation or registration directly from the action menu
  • Rename action on action menu "Review" -> "Review correction request"

Notes:

TODO:

  • Add storybook tests for quick actions

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@cibelius cibelius changed the title add tab navigation 1.10 Event UI rework Nov 3, 2025
@cibelius cibelius changed the base branch from develop to 1.10-temp November 4, 2025 11:32
aria-label={intl.formatMessage(
canAssign
? constantsMessages.assignRecord
: { id: 'user.avatar', defaultMessage: 'User avatar' }
Copy link
Contributor Author

@cibelius cibelius Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited the aria labels here to make testing easier

@cibelius cibelius marked this pull request as ready for review November 4, 2025 12:59
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@rikukissa rikukissa changed the title 1.10 Event UI rework v2.0 Event UI rework Nov 4, 2025
@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-10824.e2e-k8s.opencrvs.dev

@naftis
Copy link
Member

naftis commented Nov 5, 2025

Navigating with keyboard seems to work, good job.

image

Could you fix the "Skip to main content" text while you're at it?

@cibelius
Copy link
Contributor Author

cibelius commented Nov 5, 2025

All except one flaky test passed here: https://github.com/opencrvs/e2e/actions/runs/19096776756/job/54559647419

@cibelius cibelius merged commit 8b570aa into 1.10-temp Nov 5, 2025
82 of 84 checks passed
@cibelius cibelius deleted the ocrvs-10824 branch November 5, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants