Skip to content

Conversation

@tareq89
Copy link
Contributor

@tareq89 tareq89 commented Nov 3, 2025

Description

#10780

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@tareq89 tareq89 self-assigned this Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Important Files Changed

File Analysis

Filename Score Overview
packages/client/eslint.config.js 5/5 Added plugin:react-hooks/recommended to enforce React Hooks rules
packages/client/src/v2-events/features/events/useEvents/procedures/get.ts 2/5 Converted nested functions with hooks to proper hook functions. Performance issue: both useViewEvent and useSuspenseQuery execute unconditionally.
packages/client/src/v2-events/features/events/actions/validate/Review.tsx 5/5 Extracted component logic into ReviewContent to ensure hooks are called at top level before early returns
packages/client/src/v2-events/features/events/actions/dedup/ReviewDuplicate.tsx 5/5 Extracted component logic into ReviewDuplicateLoaded to ensure hooks are called before early returns
packages/client/src/v2-events/components/forms/FormFieldGenerator/FormFieldGenerator.tsx 5/5 Extracted Formik render function into separate Form component to avoid hook calls inside render props

15 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@tareq89 tareq89 force-pushed the ocrvs-10780 branch 5 times, most recently from a9d301e to b5d99e6 Compare November 6, 2025 09:14
@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-10780.e2e-k8s.opencrvs.dev

@tareq89 tareq89 force-pushed the ocrvs-10780 branch 2 times, most recently from e9d98f1 to fd0ea75 Compare November 12, 2025 13:10
@tareq89 tareq89 requested a review from Zangetsu101 November 12, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants