-
Notifications
You must be signed in to change notification settings - Fork 92
Added react-hook rules to eslint #10938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tareq89
wants to merge
2
commits into
develop
Choose a base branch
from
ocrvs-10780
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| packages/client/eslint.config.js | 5/5 | Added plugin:react-hooks/recommended to enforce React Hooks rules |
| packages/client/src/v2-events/features/events/useEvents/procedures/get.ts | 2/5 | Converted nested functions with hooks to proper hook functions. Performance issue: both useViewEvent and useSuspenseQuery execute unconditionally. |
| packages/client/src/v2-events/features/events/actions/validate/Review.tsx | 5/5 | Extracted component logic into ReviewContent to ensure hooks are called at top level before early returns |
| packages/client/src/v2-events/features/events/actions/dedup/ReviewDuplicate.tsx | 5/5 | Extracted component logic into ReviewDuplicateLoaded to ensure hooks are called before early returns |
| packages/client/src/v2-events/components/forms/FormFieldGenerator/FormFieldGenerator.tsx | 5/5 | Extracted Formik render function into separate Form component to avoid hook calls inside render props |
15 files reviewed, 2 comments
packages/client/src/v2-events/features/events/useEvents/procedures/get.ts
Outdated
Show resolved
Hide resolved
packages/client/src/v2-events/features/events/useEvents/procedures/get.ts
Show resolved
Hide resolved
a9d301e to
b5d99e6
Compare
Contributor
|
Your environment is deployed to https://ocrvs-10780.e2e-k8s.opencrvs.dev |
6105017 to
a1cef09
Compare
Zangetsu101
requested changes
Nov 12, 2025
packages/client/src/v2-events/components/forms/FormFieldGenerator/FormFieldGenerator.tsx
Show resolved
Hide resolved
packages/client/src/v2-events/features/events/useEvents/procedures/get.ts
Outdated
Show resolved
Hide resolved
e9d98f1 to
fd0ea75
Compare
Zangetsu101
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#10780
Checklist