Expose collector form field values to svg context #10943
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikukissa
reviewed
Nov 4, 2025
| createdByRole: userFromUsersList.role, | ||
| status: 'Accepted', | ||
| declaration: {}, | ||
| annotation: null, |
Member
There was a problem hiding this comment.
Pass annotation through here instead please. This should then be the only change needed
Contributor
Author
There was a problem hiding this comment.
Done. I've also had to include the annotation field in the $lookup() logic see last commit
Siyasanga
force-pushed
the
Add-collector-form-field-to-handlebars-context
branch
from
24b4593 to
34d3632
Compare
The handlebars context had no access to the collector form's values
Siyasanga
force-pushed
the
Add-collector-form-field-to-handlebars-context
branch
from
34d3632 to
9265bb3
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
The $action helper returns the action object for the PRINT_CERTIFICATE action. However, when $lookup tried to resolve properties from that action object, it was creating a resolvedAction object that didn't include the annotation field, even though annotation is a valid property of all actions (it's defined in the ActionBase schema).
rikukissa
approved these changes
Nov 4, 2025
Siyasanga
force-pushed
the
Add-collector-form-field-to-handlebars-context
branch
from
3e992db to
22b23a7
Compare
|
This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #10286
Description
Checklist
Note
Expose print-certificate collector form (annotation) values to the Handlebars template context and include them in $lookup/$action resolution.
annotation(collector form values) in optimisticPRINT_CERTIFICATEaction inpackages/client/src/v2-events/features/events/actions/print-certificate/Review.tsx.action.data.annotationin Handlebars$lookup/$actioncontext withinpackages/client/src/v2-events/features/events/actions/print-certificate/pdfUtils.ts, enabling templates to reference collector form fields.Written by Cursor Bugbot for commit 3851d99. This will update automatically on new commits. Configure here.