feat: add support to form in action modals #11094
Conversation
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
|
Can we use the component Dialog This PR is using the deprecated ResponsiveModel |
...Overview/components/EventHistory/EventHistoryDialog/components/ActionTypeSpecificContent.tsx
Outdated
Show resolved
Hide resolved
|
Some styling issues 
|
packages/commons/src/events/utils.ts
Outdated
| export function getCustomActionFields(eventConfig: EventConfig): FieldConfig[] { | ||
| const customActions = eventConfig.actions.filter( | ||
| (action): action is CustomActionConfig => action.type === ActionType.CUSTOM | ||
| ) satisfies CustomActionConfig[] | ||
|
|
||
| if (!customActions.length) { | ||
| return [] | ||
| } | ||
|
|
||
| return customActions.flatMap((action) => action.form) | ||
| } |
There was a problem hiding this comment.
This would currently cause issues if we have fields with the same id in different custom actions.
We should not get the fields for all custom actions, instead just the fields of the custom action we are executing now.
Lets use this function for getting the config of the correct action: https://github.com/opencrvs/opencrvs-core/blob/develop/packages/commons/src/events/utils.ts#L100
There was a problem hiding this comment.
Done here
Refactored to call custom action configs with improved types. Leave any improvement suggestions if necessary.
| expect(sanitizeForSnapshot(event, UNSTABLE_EVENT_FIELDS)).toMatchSnapshot() | ||
| }) | ||
|
|
||
| // @todo - un-skip after implementing validation for error field input |
There was a problem hiding this comment.
Is this not implemented yet?
Description
Country Config PR: opencrvs/opencrvs-countryconfig#1155
Farajaland PR: opencrvs/opencrvs-farajaland#1840
Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.
Link this pull request to the GitHub issue (and optionally name the branch
ocrvs-<issue #>)Checklist