-
Notifications
You must be signed in to change notification settings - Fork 92
New declaration review page action UI #11184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
packages/client/src/v2-events/features/events/actions/declare/DeclareActionMenu.tsx
Outdated
Show resolved
Hide resolved
bug-on-modal.mp4There seems to be a bug on the action modal. When I press the cross button, the action seems to be accepted anyway. (0:24 on the recording) After fixing it, also including it in an interaction test should be helpful. |
packages/client/src/v2-events/features/events/actions/declare/Review.interaction.stories.tsx
Outdated
Show resolved
Hide resolved
|
Could the actions returned by |
Nil20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Cool work 👍
Description
Farajaland PR: opencrvs/opencrvs-farajaland#1851
CC PR: opencrvs/opencrvs-countryconfig#1166
See video on Slack:
https://opencrvsworkspace.slack.com/archives/C02LU432JGK/p1764509696763479
Checklist