Skip to content

Conversation

@cibelius
Copy link
Contributor

@cibelius cibelius commented Nov 26, 2025

Description

Farajaland PR: opencrvs/opencrvs-farajaland#1851
CC PR: opencrvs/opencrvs-countryconfig#1166

See video on Slack:
https://opencrvsworkspace.slack.com/archives/C02LU432JGK/p1764509696763479

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@cibelius cibelius changed the title progress with new declaring ui New declaration review page action UI Nov 30, 2025
@cibelius cibelius marked this pull request as ready for review November 30, 2025 13:26
@Nil20
Copy link
Contributor

Nil20 commented Dec 1, 2025

bug-on-modal.mp4

There seems to be a bug on the action modal. When I press the cross button, the action seems to be accepted anyway. (0:24 on the recording)

After fixing it, also including it in an interaction test should be helpful.

@Nil20
Copy link
Contributor

Nil20 commented Dec 1, 2025

Could the actions returned by useAllowedActionConfigurations be different from the DeclareActionMenu? Shouldn't they be the same regardless of a record's state? 🤔

Copy link
Contributor

@Nil20 Nil20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Cool work 👍

@cibelius cibelius merged commit 0b1a6d0 into develop Dec 1, 2025
35 checks passed
@cibelius cibelius deleted the declaring-poc branch December 1, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants