Skip to content

Conversation

@cibelius
Copy link
Contributor

@cibelius cibelius commented Dec 3, 2025

Description

CC PR: opencrvs/opencrvs-countryconfig#1167
Farajaland PR: opencrvs/opencrvs-farajaland#1856

Resolves: #10267
Also fix bug: #11224

  • Replace the EventStatus.VALIDATED with a flag 'validated'.
  • Also add support for configuring reject-action.

We have an issue about removing the VALIDATE-action altogether and replacing it with a custom action here:
#11225

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@cibelius cibelius changed the title progress with removing validated status Replace VALIDATED-status with a flag Dec 3, 2025
@cibelius cibelius changed the title Replace VALIDATED-status with a flag Replace EventStatus VALIDATED with flag 'validated' Dec 3, 2025
@cibelius cibelius marked this pull request as ready for review December 3, 2025 13:12
Comment on lines +24 to +26
// @TODO: This is a temporary measure, until the VALIDATE-action is turned in to a custom action.
// At that point we should remove all logic and mentions of the validate action in core.
// Related issue: https://github.com/opencrvs/opencrvs-core/issues/11225
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also the reason why 'Validated' was not made into a InherentFlag or any constant in core

@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-10267-b.e2e-k8s.opencrvs.dev

@cibelius
Copy link
Contributor Author

cibelius commented Dec 5, 2025

Will merge as only the form-state.spec.ts test failed, which is failing currently on all PRs:
https://github.com/opencrvs/e2e/actions/runs/19963082681/job/57251182869

@cibelius cibelius enabled auto-merge (squash) December 5, 2025 13:46
@cibelius cibelius disabled auto-merge December 5, 2025 13:46
@cibelius cibelius merged commit e8db33a into develop Dec 5, 2025
83 of 84 checks passed
@cibelius cibelius deleted the ocrvs-10267-b branch December 5, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: change status: Validated to be a flag

5 participants