-
Notifications
You must be signed in to change notification settings - Fork 92
Feat: placeOfEvent #11246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feat: placeOfEvent #11246
Conversation
e9bcdf4 to
2ea4797
Compare
makelicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍 Left few comments to clarify
93784ac to
ec348a8
Compare
e5c28be to
e68b4b4
Compare
|
Your environment is deployed to https://ocrvs-11148.e2e-k8s.opencrvs.dev |
e6ecf7b to
55b5ff2
Compare
makelicious
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If event happens in an office that is at the top level, what will the array include? Could we ensure that other office worker with administrativeArea jurisdiction actually finds these?
Since they refer to NULL I'm wondering should it actually be part of the array 😬
The array will only include the location id, one item. I think it is upto us how office worker with |
…e default/derived values and conditional inclusion in form submissions.
issue: #11148
Add
placeOfEventResolution and Indexing SupportThis pull request adds full support for resolving and indexing the
placeOfEventvalue for events.The value may come from configured form fields or fall back to
createdAtLocation.What's Included
1.
resolvePlaceOfEvent()Implementationconfig.placeOfEventfields in priority order.administrativeArea).eventMetadata.createdAtLocationwhen no valid field value exists.2. EventConfig Validation
3. Elasticsearch Indexing Support
placeOfEventmapping consistent withcreatedAtLocation.4. Test Coverage
Includes tests for:
Breaking Changes
placeOfEventconfigurations now throw validation errors.