chore: add new icon to components and toolkit #11278
Merged
+37
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
cibelius
reviewed
Dec 12, 2025
Comment on lines
+597
to
+604
| .filter((action) => | ||
| configurableEventScopeAllowed( | ||
| scopes, | ||
| ['record.custom-action'], | ||
| event.type, | ||
| action.customActionType | ||
| ) | ||
| ) |
Contributor
There was a problem hiding this comment.
I thought this was already done somewhere, as custom actions didnt show up unless you had the scope for it! I was mistaken I guess 😲
Contributor
Author
There was a problem hiding this comment.
yeah! we weren't giving multiple custom action scopes to a single user, that's probably why it wasn't caught until now
cibelius
approved these changes
Dec 12, 2025
Contributor
Author
|
Successful e2e run: https://github.com/opencrvs/e2e/actions/runs/20174648077 |
Contributor
|
Your environment is deployed to https://ocrvs-11271.e2e-k8s.opencrvs.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Country Config PR: opencrvs/opencrvs-countryconfig#1181
Farajaland PR: opencrvs/opencrvs-farajaland#1872
Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.
Link this pull request to the GitHub issue (and optionally name the branch
ocrvs-<issue #>)Checklist