chore: Cleaned up the national ID integration code

[PathumN99]

#7909

• Removed the national ID select option in integrations UI.
• Removed the national ID scope in backend.
• Removed the relevant translations from the country-config. [#313]
• Removed MOSIP systemType in GraphQL schemas.

[github-actions]

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

• Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
• Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
• If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

[naftis]

👍 Thanks, looks good.

opencrvs-core/packages/client/src/tests/schema.graphql

Line 864 in 02b2eee

MOSIP

opencrvs-core/packages/gateway/src/features/systems/schema.graphql

Line 31 in de0776f

MOSIP

we could also remove it in these GraphQL schemas and then run frontend type generation:

cd packages/client
TOKEN="" yarn generate-gateway-types

https://is-my-opencrvs-up.netlify.app/
you can find the registrar's token in the left panel when you are running the app locally

[tahmidrahman-dsi]

@PathumN99 I think you might have to take care of these cases as well

https://github.com/opencrvs/opencrvs-core/blob/5c402ea/packages/webhooks/src/features/event/service.ts#L59-L60
https://github.com/opencrvs/opencrvs-core/blob/5c402ea/packages/webhooks/src/features/event/service.ts#L74-L75

If you get rid of these cases. then the functions transformBirthBundle, transformDeathBundle will be mostly redundant.
Then you can also get rid of those functions.

Then in the file packages/webhooks/src/features/event/handler.ts you can do something like this

-        const transformedBundle = transformBirthBundle(
-          bundle,
-          webhookToNotify.createdBy.type,
-          permissions
-        )
+        let finalBundle: RegisteredRecord
+        if (webhookToNotify.createdBy.type === 'webhook') {
+          finalBundle = getPermissionsBundle(bundle, permissions)
+        } else {
+          finalBundle = bundle
+        }
         if (webhookToNotify.trigger === TRIGGERS[TRIGGERS.BIRTH_REGISTERED]) {
           const payload = {
             timestamp: new Date().toISOString(),
@@ -80,7 +80,7 @@ export async function birthRegisteredHandler(
               hub: {
                 topic: TRIGGERS[TRIGGERS.BIRTH_REGISTERED]
               },
-              context: [transformedBundle]
+              context: [finalBundle]
             }
           }

Consider making similar changes to both birthRegisteredHandler and deathRegisteredHandler

[tahmidrahman-dsi]

@PathumN99 Nice work! Please have a look at the comment I made about the webhooks handlers

[tahmidrahman-dsi]

Good one @PathumN99, thank you

[tahmidrahman-dsi]

@PathumN99 one small test case needs to be removed to pass unit tests for webhooks

opencrvs-core/packages/webhooks/src/features/event/service.test.ts

Lines 1607 to 1611 in 764d1b0

	it('transforms national id integration bundle', () => {
	const bundle = transformBirthBundle(registeredRecord, 'nationalId')
	expect(bundle).toEqual(nationalIdBundle)
	})

Also after you remove this test case, please consider removing subsequent unused codes

[naftis]

@PathumN99 on approval / ready to merge label, you can merge the pull request to develop if the tests pass.

[ocrvs-bot]

Your environment is deployed to https://ocrvs-7909.opencrvs.dev