Skip to content

Conversation

@PathumN99
Copy link
Collaborator

@PathumN99 PathumN99 commented Nov 20, 2024

#7818

  • Refactoring specific API endpoints to use node-fetch calls instead of proxying from the gateway to the auth microservice.
  • Replaced AUTH_URL usages in client & login apps with API_GATEWAY_URL/api/auth
  • Removed Traefik configurations that exposes auth to the public internet (#329 in country-config)

@github-actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@PathumN99 PathumN99 requested a review from naftis November 20, 2024 06:44
@PathumN99 PathumN99 changed the title refactor[DRAFT]: Hide auth behind one URL refactor: Hide auth behind one URL Nov 20, 2024
@naftis
Copy link
Member

naftis commented Nov 20, 2024

Looks good so far! 👍

@PathumN99 PathumN99 marked this pull request as ready for review November 26, 2024 10:22
@PathumN99 PathumN99 requested a review from naftis November 26, 2024 10:22
@naftis
Copy link
Member

naftis commented Dec 10, 2024

I'm closing this as it's not currently a priority. I'll get back to this PR when we prioritize it for 1.7 or 1.8.

@naftis naftis closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants