-
Notifications
You must be signed in to change notification settings - Fork 92
chore: migrate from yarn to pnpm #9658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- remove package.json pnpm module resolutions which was added to restrict modules from upgrading to versions. We might eventually need to upgrade deps like @type/node as we upgraded node. But it can be under scope of another task
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
…we are not sending any request body
|
This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs. |
tahmidrahman-dsi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still several places where I had to provide explicitly any as type to get things functional. Need to take care of those. Before they were implicit anys.
| ) | ||
| } | ||
|
|
||
| const role = await createFhirPractitionerRole(user, practitionerId, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unnecessary await
| practitionerId: string, | ||
| system: boolean | ||
| ): Promise<fhir.PractitionerRole> => { | ||
| ): fhir.PractitionerRole => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing async operation done in this function, thus removed async
| } | ||
| interface ServerInjectResponse { | ||
| statusCode: number | ||
| payload: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todo figure out a way to replace 'any'
| * It is needed in projects that use Yarn PnP or are set up within a monorepo. | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| function getAbsolutePath(value: string): any { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
|
This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs. |
|
This PR has been automatically closed because it has been inactive for 30 days. Please reopen if you are still working on it. |
Description
This PR migrates our package manager from yarn to pnpm.
Checklist