Skip to content

Conversation

@tahmidrahman-dsi
Copy link
Contributor

@tahmidrahman-dsi tahmidrahman-dsi commented May 30, 2025

Description

This PR migrates our package manager from yarn to pnpm.

Checklist

  • I have linked the correct Github issue under "Development"
  • Make sure project runs locally
  • Make sure unit tests run with success
  • Make sure e2e tests run with success
  • Make sure workflow files are correctly updated and run without errors
  • Update references of yarn with pnpm in docs
  • Update setup.sh script and test. Make sure it runs with success
  • Update CHANGELOG.md
  • Update in countryconfig repo

@tahmidrahman-dsi tahmidrahman-dsi self-assigned this May 30, 2025
@github-actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@tahmidrahman-dsi tahmidrahman-dsi temporarily deployed to choremigrate-to-pnpm May 30, 2025 06:06 — with GitHub Actions Inactive
@tahmidrahman-dsi tahmidrahman-dsi linked an issue May 30, 2025 that may be closed by this pull request
3 tasks
@tahmidrahman-dsi tahmidrahman-dsi changed the title chore: migrate to pnpm chore: migrate from yarn to pnpm May 30, 2025
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs.

@github-actions github-actions bot added the Stale The pr is inactive label Sep 1, 2025
Copy link
Contributor Author

@tahmidrahman-dsi tahmidrahman-dsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still several places where I had to provide explicitly any as type to get things functional. Need to take care of those. Before they were implicit anys.

)
}

const role = await createFhirPractitionerRole(user, practitionerId, false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unnecessary await

practitionerId: string,
system: boolean
): Promise<fhir.PractitionerRole> => {
): fhir.PractitionerRole => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing async operation done in this function, thus removed async

}
interface ServerInjectResponse {
statusCode: number
payload: any
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@todo figure out a way to replace 'any'

* It is needed in projects that use Yarn PnP or are set up within a monorepo.
*/
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function getAbsolutePath(value: string): any {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@github-actions github-actions bot removed the Stale The pr is inactive label Sep 9, 2025
@github-actions
Copy link

This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs.

@github-actions github-actions bot added the Stale The pr is inactive label Sep 29, 2025
@github-actions
Copy link

This PR has been automatically closed because it has been inactive for 30 days. Please reopen if you are still working on it.

@github-actions github-actions bot closed this Oct 10, 2025
@github-actions github-actions bot removed the Stale The pr is inactive label Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from yarn to pnpm

2 participants