Skip to content

Conversation

@rikukissa
Copy link
Member

@rikukissa rikukissa commented Oct 15, 2025

Data directories and cryptfs should only exist on manager node.

Root cause

Docker service had been made dependant on CryptFS both in manager and worker machines. Worker machines do not hold any data, meaning they do not have cryptfs either. Event the shell scripts required to create the encryption do not exist on these machines.

Fix

The logic is now so the dependency is only made between docker and cryptfs on manager nodes. I also made it so if this dependency had been created for a machine earlier, it is now removed.

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

…a directories and cryptfs should only exist on manager node
@github-actions
Copy link
Contributor

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Copy link
Contributor

@makelicious makelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems logical

tags:
- traefik

# Ensure incorrectly created override of docker daemon (1.9 beta) is removed on workers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one off?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, state: absent ensures the file is not in place anymore

@rikukissa rikukissa merged commit bd099fa into develop Oct 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants