Ensure docker daemon does not depend on cryptfs logic on workers #1092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data directories and cryptfs should only exist on manager node.
Root cause
Docker service had been made dependant on CryptFS both in manager and worker machines. Worker machines do not hold any data, meaning they do not have cryptfs either. Event the shell scripts required to create the encryption do not exist on these machines.
Fix
The logic is now so the dependency is only made between docker and cryptfs on manager nodes. I also made it so if this dependency had been created for a machine earlier, it is now removed.
Checklist