-
Notifications
You must be signed in to change notification settings - Fork 69
Bump mosip-api to 1.9.0-beta.4 and fetch NID & id type #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6126415
019271e
a327847
c4382db
756d6dd
82bebc7
6b5185c
98687f9
b8bece1
63f5bc3
e5f012c
4c8b8e2
e3a6ced
7d4a1b2
080c05d
e4dff72
bae598b
131d282
b4ba21c
0e528b9
0c9a53a
669dab6
1143000
5c42c1a
889595c
abcfbbb
4b88a53
3953437
4160594
80027a3
6f535c9
387b75f
6ae2e96
4c2e028
826f144
88d4f9d
d25a9f5
7007ce0
ec82efe
4ace5bd
cca9655
b679f5c
bff213e
74ef678
fdb0752
bd6c0d9
560fce9
535460a
647dcf2
5043078
d3bed63
cf7b07f
707e1a5
315ca70
d84a3e7
48c109c
c1b3a37
8e7a197
748f872
2e5b80e
7887bf8
3604833
4662fe6
ed952ac
be0d367
3700f8f
5db2f49
434ed79
4fdc4bd
712f644
dfc00d7
a547ca5
ac457b8
635ae57
7431d84
a9fd8c1
afe1167
3e81430
b9c3832
8745ed8
95a1db5
5365a0a
986c361
3b56e61
dc5c15d
fb0cd4c
db8620b
666f732
df465a0
6bb2dbf
37e77e4
bad09ee
991d17f
be043e7
7e42b3d
295d7fa
b98c65c
d3994c3
14a88cd
f4e99d4
916116c
658a212
e74a7dd
8fc7c8b
3109d78
96f68e3
c8f75d0
9737a0b
04f9600
2358e08
e93fa9e
96f68a6
9a0dfc8
d66d145
2ef6dc6
a0c23cc
a58814c
833403d
43d90f6
ff87a4a
83b895f
dd7a372
ba4433b
197cc22
9dbc048
81e2ffb
f16d7ad
628d1dc
7331a82
11620b6
7332839
85754c9
59e5196
e657160
0322834
16746ba
f292dda
dc17244
74d54ca
236fe8f
fa4fed6
916bf05
d3c902d
7a48a27
1dccd3e
99ca30b
223fb4f
4e7936f
1ec5cb2
d72770a
fef6d51
0cda088
069008d
69801bc
832cbb8
38988d5
eb67a66
6ab2194
fcbb36b
dd7fdcc
04197f2
df43917
4917739
05ffe2c
98abe34
1f18c8f
aa449a3
ee82a15
fdf550c
4edaf5e
f0d93f4
806c2a1
c0d7a86
7eae581
d1ab8bb
db1fb62
e81d1d2
658c72c
377e241
396d084
97c8af4
d380dd7
a175c18
de50ce1
ed4549a
3527883
feb5fde
861d683
2c5a604
34790b2
c8f7371
73e24a2
1a9679a
2f9a358
519887e
72b8222
5a2b1e2
c716ff6
254e1c1
c1265d0
6c5cb95
f0ad990
8b257a7
c3eba4e
d7030a1
17ae4d6
43ab9a9
01e5801
0a13bca
b630975
3cc676a
9b9508e
f55216b
4fa6277
8778aa6
f6b1f2e
901d73d
fd13ccb
c17dd13
73e3246
4c4f5b9
a390ce8
007aa1f
a0db35c
9064eef
f7255fd
9468253
9c9a698
7008f31
c12dc99
78e1e04
8ff2b50
805768f
4a69059
b706275
5d5057c
8aa3b3a
891a40d
36cea97
b77f974
cc37092
018342e
0f94087
ccaf359
e8131cc
77ba894
4578add
e35b5d6
ddae349
708574d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,5 +156,10 @@ echo "✅ Database and roles dropped." | |
| echo "🚀 Reinitializing Postgres with on-deploy.sh..." | ||
|
|
||
| docker service update --force opencrvs_postgres-on-update | ||
| # Delete all data from SQLite | ||
| # --------------------------- | ||
| docker run --rm -v /data/sqlite:/data/sqlite alpine \ | ||
| sh -c "apk add --no-cache sqlite && sqlite3 /data/sqlite/mosip-api.db 'DELETE FROM transactions;'" | ||
|
Comment on lines
+161
to
+162
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: The DELETE operation lacks error handling. If the table doesn't exist or the database is locked, the script will exit due to Prompt To Fix With AIThis is a comment left during a code review.
Path: infrastructure/clear-all-data.sh
Line: 161:162
Comment:
**style:** The DELETE operation lacks error handling. If the table doesn't exist or the database is locked, the script will exit due to `set -e` on line 12 without providing clear feedback about the SQLite cleanup failure.
How can I resolve this? If you propose a fix, please make it concise. |
||
|
|
||
| echo "✅ All data cleared." | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,3 @@ | ||
| # | ||
| # Production deployments of OpenCRVS should never be exposed to the internet. | ||
| # Instead, they should be deployed on a private network and exposed to the internet via a VPN. | ||
| # | ||
| # Before you deploy staging or production environments, make sure the application servers are | ||
| # either in an internal network or protected with a firewall. No ports should be exposed to the internet. | ||
| # | ||
|
|
||
| services: | ||
| gateway: | ||
| environment: | ||
|
|
@@ -88,29 +80,6 @@ services: | |
| environment: | ||
| - NODE_ENV=production | ||
|
|
||
| countryconfig: | ||
| image: ${DOCKERHUB_ACCOUNT}/${DOCKERHUB_REPO}:${COUNTRY_CONFIG_VERSION} | ||
| restart: unless-stopped | ||
| secrets: | ||
| - jwt-public-key.{{ts}} | ||
| environment: | ||
| - NODE_ENV=production | ||
| - FHIR_URL=http://hearth:3447/fhir | ||
| - AUTH_URL=http://auth:4040 | ||
| - APPLICATION_CONFIG_URL=http://config:2021 | ||
| - CONFIRM_REGISTRATION_URL=http://workflow:5050/confirm/registration | ||
| - CHECK_INVALID_TOKEN=true | ||
| - SENTRY_DSN=${SENTRY_DSN:-} | ||
| - SENDER_EMAIL_ADDRESS=${SENDER_EMAIL_ADDRESS} | ||
| - ALERT_EMAIL=${ALERT_EMAIL} | ||
| - SMTP_HOST=${SMTP_HOST} | ||
| - SMTP_PORT=${SMTP_PORT} | ||
| - SMTP_USERNAME=${SMTP_USERNAME} | ||
| - SMTP_PASSWORD=${SMTP_PASSWORD} | ||
| - SMTP_SECURE=${SMTP_SECURE} | ||
| deploy: | ||
| replicas: 1 | ||
|
|
||
| client: | ||
| environment: | ||
| - DECLARED_DECLARATION_SEARCH_QUERY_COUNT=100 | ||
|
|
@@ -150,36 +119,12 @@ services: | |
| - REPLICAS=1 | ||
|
|
||
| traefik: | ||
| # These templates use an Automatic Certificate Management Environment (Let's Encrypt). | ||
| # This makes sure that the HTTPS certificates are automatically generated and renewed without manual maintenance. | ||
| # | ||
| # This default configuration will only work if OpenCRVS is directly accessible from the internet. | ||
| # | ||
| # WE STRONGLY RECOMMEND THAT YOU DO NOT EXPOSE PRODUCTION OPENCRVS TO THE INTERNET! | ||
| # | ||
| # If you are deploying OpenCRVS in a private network, you have two options: | ||
| # 1. Use a DNS provider that supports ACME DNS-01 challenges. | ||
| # 2. Use a manually renewed certificate file. | ||
|
|
||
| # For your country to use the DNS-01 challenge, your domain's DNS provider must be one of the ones listed here | ||
| # https://doc.traefik.io/traefik/https/acme/#providers | ||
| # | ||
| # If your DNS provider is not listed, you can use manually renewed certificate files instead of Let's Encrypt. | ||
| # To do this, remove the `environment` and `certificatesresolvers.certResolver.acme` sections and uncomment the following lines. | ||
| # You will also need to place your certificates in the `/data/traefik/certs` directory. | ||
| # Ensure that the file names match the ones defined below. | ||
| # | ||
| # volumes: | ||
| # - /var/run/docker.sock:/var/run/docker.sock | ||
| # - /data/traefik/certs:/certs | ||
| # command: | ||
| # - --tls.certificates.certfile=/certs/crvs.cm.crt | ||
| # - --tls.certificates.keyfile=/certs/crvs.cm.key | ||
| # - --tls.certificates.stores=default | ||
| # - --tls.stores.default.defaultcertificate.certfile=/certs/crvs.cm.crt | ||
| # - --tls.stores.default.defaultcertificate.keyfile=/certs/crvs.cm.key | ||
|
|
||
| networks: | ||
| - overlay_net | ||
| command: | ||
| # Use HTTP-01 challenge as the web server is publicly available | ||
| # https://doc.traefik.io/traefik/https/acme/#httpchallenge | ||
| # For DNS-01 challenge and manual certificates, check staging and production configurations | ||
| - --certificatesresolvers.certResolver.acme.email=riku@opencrvs.org | ||
| - --certificatesresolvers.certResolver.acme.storage=acme.json | ||
| - --certificatesresolvers.certResolver.acme.caserver=https://acme-v02.api.letsencrypt.org/directory | ||
|
|
@@ -201,3 +146,57 @@ services: | |
| - --accesslog=true | ||
| - --accesslog.format=json | ||
| - --ping=true | ||
|
|
||
| countryconfig: | ||
| image: ${DOCKERHUB_ACCOUNT}/${DOCKERHUB_REPO}:${COUNTRY_CONFIG_VERSION} | ||
| restart: unless-stopped | ||
| secrets: | ||
| - jwt-public-key.{{ts}} | ||
| environment: | ||
| - NODE_ENV=production | ||
| - QA_ENV=true | ||
| - FHIR_URL=http://hearth:3447/fhir | ||
| - AUTH_URL=http://auth:4040 | ||
| - APPLICATION_CONFIG_URL=http://config:2021 | ||
| - CONFIRM_REGISTRATION_URL=http://workflow:5050/confirm/registration | ||
| - CHECK_INVALID_TOKEN=true | ||
| - MONGO_URL=mongodb://mongo1/user-mgnt?replicaSet=rs0 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: MONGO_URL is missing authentication credentials (compare with line 44: Prompt To Fix With AIThis is a comment left during a code review.
Path: infrastructure/docker-compose.staging-deploy.yml
Line: 163:163
Comment:
**logic:** MONGO_URL is missing authentication credentials (compare with line 44: `user-mgnt:${USER_MGNT_MONGODB_PASSWORD}@mongo1`). This will likely fail to connect to the secured MongoDB instance.
How can I resolve this? If you propose a fix, please make it concise. |
||
| - SENTRY_DSN=${SENTRY_DSN:-} | ||
| - SENDER_EMAIL_ADDRESS=${SENDER_EMAIL_ADDRESS} | ||
| - ALERT_EMAIL=${ALERT_EMAIL} | ||
| - SMTP_HOST=${SMTP_HOST} | ||
| - SMTP_PORT=${SMTP_PORT} | ||
| - SMTP_USERNAME=${SMTP_USERNAME} | ||
| - SMTP_PASSWORD=${SMTP_PASSWORD} | ||
| - SMTP_SECURE=${SMTP_SECURE} | ||
| - ESIGNET_REDIRECT_URL=${ESIGNET_REDIRECT_URL} | ||
| - OPENID_PROVIDER_CLIENT_ID=${OPENID_PROVIDER_CLIENT_ID:-} | ||
| - OPENID_PROVIDER_CLAIMS=${OPENID_PROVIDER_CLAIMS:-} | ||
| - MOSIP_API_USERINFO_URL=${MOSIP_API_USERINFO_URL:-} | ||
| deploy: | ||
| replicas: 1 | ||
| networks: | ||
| - overlay_net | ||
|
|
||
|
|
||
| mosip-api: | ||
| volumes: | ||
| - /certs:/certs:ro | ||
| environment: | ||
| - CREDENTIAL_PARTNER_CERTIFICATE_PATH=/certs/credential-partner.csr | ||
| - CREDENTIAL_PARTNER_PRIVATE_KEY_PATH=/certs/credential-partner.pem | ||
|
Comment on lines
+186
to
+187
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Using Prompt To Fix With AIThis is a comment left during a code review.
Path: infrastructure/docker-compose.staging-deploy.yml
Line: 186:187
Comment:
**logic:** Using `.csr` extension for certificate path is incorrect—CSRs are certificate signing *requests*, not certificates. Should this be `.crt` or `.pem`? Was `.csr` intended here, or should this be the actual certificate file (typically `.crt` or `.pem`)?
How can I resolve this? If you propose a fix, please make it concise. |
||
| - MOSIP_PACKET_AUTH_CLIENT_ID=${MOSIP_PACKET_AUTH_CLIENT_ID} | ||
| - MOSIP_PACKET_AUTH_CLIENT_SECRET=${MOSIP_PACKET_AUTH_CLIENT_SECRET} | ||
| - MOSIP_WEBSUB_AUTH_CLIENT_ID=${MOSIP_WEBSUB_AUTH_CLIENT_ID} | ||
| - MOSIP_WEBSUB_AUTH_CLIENT_SECRET=${MOSIP_WEBSUB_AUTH_CLIENT_SECRET} | ||
| - MOSIP_AUTH_PASS=${MOSIP_AUTH_PASS} | ||
| - MOSIP_AUTH_URL=${MOSIP_AUTH_URL} | ||
| - MOSIP_AUTH_USER=${MOSIP_AUTH_USER} | ||
| - MOSIP_GENERATE_AID_URL=${MOSIP_GENERATE_AID_URL} | ||
| - MOSIP_BIRTH_WEBHOOK_URL=${MOSIP_BIRTH_WEBHOOK_URL} | ||
| - MOSIP_DEATH_WEBHOOK_URL=${MOSIP_DEATH_WEBHOOK_URL} | ||
| logging: | ||
| driver: gelf | ||
| options: | ||
| gelf-address: 'udp://127.0.0.1:12201' | ||
| tag: 'esignet-mock' | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: The container installs
sqliteevery time this script runs, which is inefficient. Consider using a base image that already hassqliteinstalled, or cache the installation if this script is run frequently.Prompt To Fix With AI