Config update #1114

tahmidrahman-dsi · 2025-10-23T06:24:42Z

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

I have linked the correct Github issue under "Development"
I have tested the changes locally, and written appropriate tests
I have tested beyond the happy path (e.g. edge cases, failure paths)
I have updated the changelog with this change (if applicable)
I have updated the GitHub issue status accordingly

…yconfig into develop

* feat: add configuration to implement logic before forwarding to mosip for id creation * chore: bump mosip package version * fix: amends to verify approach * fix: minimize changes * fix: add logs * fix: minor improvements

Added vadym mudryi to development and e2e servers

…config into release-v1.7.0

fix: Added vadym mudryi to opencrvs servers, disabled niko

feat/disable fields when verified or authenticated

Release v1.7.0

fix: wait for assignment to propagate

* add development time yarn db:clear:all script for easy analytics data clearing * fix indent * add translation * fix street level address validation * add ids to data config fields * drop analytics database as part of data clearing * cleanup * fix: death informant phone number error message * add 'ConditionalType.DISPLAY_ON_REVIEW' * use new conditional * use ConditionalType.DISPLAY_ON_REVIEW * missing translation added * fix * fix: remove print in advance from death form of print cert (opencrvs#1071) * fix: remove print in advance from death form of print cert * fix: remove print in advancefor other collector type * update metabase dump * fix: dont show birth certificate after first print * [OCRVS-10730] Remove 'Completeness Rates Dashboard'/ 'Vital Statistics Export' links in registration dashboard * [OCRVS-10729] Metabase copy cleanup * [OCRVS-10722] Remove Jurisdiction filter from Registrations dashboards * chore: update toolkit version * feat: use the new age field in birth form * chore: upgrade toolkit version * feat: use new AGE field * [OCRVS-10729] Remove location filter value completely from registrations dashboards title * Ensure docker daemon does not depend on cryptfs logic on workers. Data directories and cryptfs should only exist on manager node * fix: Place of death in advanced search * fix(analytics): clear existing event_actions before upsert and mark last action as accepted on immediate confirmation (opencrvs#1094) * feat: add validations to age field * chore: upgrade toolkit version * Metabase: add country wide completeness rate * Metabase: update dashboards * Metabase: update readme * update toolkit * update toolkit --------- Co-authored-by: Riku Rouvila <[email protected]> Co-authored-by: cibelius <[email protected]> Co-authored-by: tareq89 <[email protected]> Co-authored-by: jamil314 <[email protected]> Co-authored-by: Md. Ashikul Alam <[email protected]> Co-authored-by: Tameem Bin Haider <[email protected]> Co-authored-by: Tameem Bin Haider <[email protected]> Co-authored-by: naftis <[email protected]>

…yconfig into develop

fix: hidden fields should not receive a value

* fix: backend doesnt get the full http payload * dont display http or query params on review

…mosip into fix/query-param-reader-removing-review-params

…into sync-with-countryconfig-develop

Sync with countryconfig develop

…mosip into fix/query-param-reader-removing-review-params

…sabled when review

…review-params [OCRVS-10759] Fix query param reader removing review params

…d-type bumps mosip-api to 1.9.0-beta.4 and fetches nid & id type

greptile-apps

Additional Comments (1)

CHANGELOG.md, line 64-65 (link)

logic: These improvement entries are duplicated from the 1.9.0 section above (lines 13-14) and from 1.8.0(lines 54-55).

_{46 files reviewed, 47 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2025-10-23T06:25:48Z

CHANGELOG.md

+- Upgraded to `@opencrvs/mosip` v1.8.0 to support the following enhancements:
+  - Added QR code scanner form configuration, allowing users to scan QR codes and automatically prefill form fields with the extracted data. [#7939](https://github.com/opencrvs/opencrvs-core/issues/7939)
+  - Integrated E-signet authentication flow using mock identities. [#8062](https://github.com/opencrvs/opencrvs-core/issues/8062)
+  - Enabled online verification flow with mock identities. [#7944](https://github.com/opencrvs/opencrvs-core/issues/7944)
+  - Provided support for custom business logic to determine whether MOSIP processing should be triggered during registration. [#7942](https://github.com/opencrvs/opencrvs-core/issues/7942)
+  - Ensured that registering a death event deactivates the corresponding identity in MOSIP. [#7943](https://github.com/opencrvs/opencrvs-core/issues/7943)
+  - Enforced rejection of registrations if MOSIP processing fails. [#8174](https://github.com/opencrvs/opencrvs-core/issues/8174)


logic: Duplicate MOSIP v1.8.0 upgrade entry - these same features are listed in both 1.8.0 and 1.9.0 sections (lines 7-9 and 44-50). Remove from 1.8.0 section.

greptile-apps · 2025-10-23T06:25:48Z

CHANGELOG.md

+- Added Build summary and refactored deployment workflow to be more clear [#6984](https://github.com/opencrvs/opencrvs-core/issues/6984)
+- Build OpenCRVS release images for arm devices [#9455](https://github.com/opencrvs/opencrvs-core/issues/9455)


logic: Duplicate improvement entries - these are repeated from 1.9.0 section (lines 11-14) and again in 1.6.4 (lines 64-65). Remove duplicates.

greptile-apps · 2025-10-23T06:25:49Z

CHANGELOG.md

+## 1.6.4
+
 - Added a local virtual machine setup for testing Ansible playbooks locally (on MacOS and Ubuntu ). Check [provision.ipynb](infrastructure/local-development/provision.ipynb) for more details.



logic: 1.6.4 section appears twice - once here (lines 57-60) and once later (lines 272-276). Consolidate into single entry.

greptile-apps · 2025-10-23T06:25:50Z

src/form/v2/birth/forms/pages/mother.ts

+            conditional: and(requireMotherDetails)
+          }


style: Wrapping requireMotherDetails in and() with no other operands is redundant.

greptile-apps · 2025-10-23T06:25:51Z

infrastructure/docker-compose.development-deploy.yml

      - SMTP_USERNAME=${SMTP_USERNAME}
      - SMTP_PASSWORD=${SMTP_PASSWORD}
      - SMTP_SECURE=${SMTP_SECURE}
+      - ESIGNET_REDIRECT_URL=${ESIGNET_REDIRECT_URL}


logic: Missing default value for required environment variable. Unlike the other OpenID variables (lines 32-34), ESIGNET_REDIRECT_URL has no :- fallback, which will cause deployment failures if the variable is unset.

greptile-apps · 2025-10-23T06:26:19Z

src/utils/fhir.ts

+  const motherID = mother.identifier?.[0].value
+  const fatherID = father.identifier?.[0].value


logic: Unsafe non-null assertions. mother.identifier and father.identifier could be undefined or empty arrays, causing runtime errors.

greptile-apps · 2025-10-23T06:26:20Z

src/utils/fhir.ts

+    getComposition(record)
+  )
+  if (!compositionSection) return undefined
+  const personSectionEntry = compositionSection.entry![0]


logic: Unsafe non-null assertion. compositionSection.entry could be an empty array, making entry[0] undefined.

greptile-apps · 2025-10-23T06:26:21Z

src/utils/fhir.ts

+  const reference = (relatedPersonEntry?.resource as fhir3.RelatedPerson)
+    .patient.reference
+  return getFromBundleById(record, reference!.split('/')[1])


logic: Multiple unsafe non-null assertions. relatedPersonEntry?.resource, patient.reference, and the array access can all fail at runtime.

greptile-apps · 2025-10-23T06:26:21Z

src/utils/fhir.ts

+export function getInformantFullName(bundle: fhir3.Bundle) {
+  const informant = getInformantPatient(bundle)
+  return (
+    informant?.name?.[0]?.given?.join(' ') + ' ' + informant?.name?.[0]?.family


logic: Concatenation without null checks will produce 'undefined undefined' if informant or name properties are missing.

greptile-apps · 2025-10-23T06:26:22Z

src/utils/fhir.ts

+    getComposition(record)
+  )
+  if (!compositionSection) return undefined
+  const personSectionEntry = compositionSection.entry![0]


logic: Unsafe non-null assertion. compositionSection.entry could be an empty array.

naftis and others added 30 commits February 7, 2025 13:50

chore: upgrade toolkit version

b8bece1

chore: downgrade toolkit

63f5bc3

Merge branch 'develop' of https://github.com/opencrvs/opencrvs-countr…

e5f012c

…yconfig into develop

chore: add necessary env variables to mosip-api

4c8b8e2

fix: remove duplicate environment variable

e3a6ced

fix: refer to path and not the value of private key

7d4a1b2

fix: use latest env variables

080c05d

chore: expose certs to mosip-api

e4dff72

chore: add certs to esignet-mock

bae598b

feat: add configuration to implement logic (#18)

131d282

* feat: add configuration to implement logic before forwarding to mosip for id creation * chore: bump mosip package version * fix: amends to verify approach * fix: minimize changes * fix: add logs * fix: minor improvements

Added vadym mudryi to development and e2e servers

b4ba21c

Merge pull request #1224 from opencrvs/add-vmudryi-to-users

0e528b9

Added vadym mudryi to development and e2e servers

fix: pass request and h to the handlers

0c9a53a

chore: always forward to id system for now

669dab6

feat: handle incomplete declarations

1143000

chore: add conditional for disabling field when verified, authenticated

5c42c1a

chore: apply new conditional in birth form

889595c

chore: apply new conditional in death form

abcfbbb

fix: show certification date instead of registration (opencrvs#416)

4b88a53

Merge branch 'release-v1.7.0' of github.com:opencrvs/opencrvs-country…

3953437

…config into release-v1.7.0

chore: comment out mosip related info

4160594

fix: Added vadym mudryi to opencrvs servers, disabled niko

80027a3

fix: update snapshot

6f535c9

Merge pull request #1225 from opencrvs/ocrvs-8632

387b75f

fix: Added vadym mudryi to opencrvs servers, disabled niko

fix: add missed out conditional

6ae2e96

Merge pull request #19 from opencrvs/feat/disable-fields-when-verified

4c2e028

feat/disable fields when verified or authenticated

Merge pull request #1212 from opencrvs/release-v1.7.0

826f144

Release v1.7.0

fix: wait for assignment to propagate

88d4f9d

fix: add resolveJsonModule flag

d25a9f5

Merge pull request #1227 from opencrvs/fix/e2e-death-test

7007ce0

fix: wait for assignment to propagate

tahmidrahman-dsi and others added 28 commits October 17, 2025 09:14

chore: query-param form projection (#52)

78e1e04

Merge branch 'develop' of https://github.com/opencrvs/opencrvs-countr…

805768f

…yconfig into develop

fix: hidden fields should not receive a value

4a69059

Merge pull request #54 from opencrvs/fix-hidden-field-values

b706275

fix: hidden fields should not receive a value

fix: backend doesnt get the full http payload (#55)

5d5057c

* fix: backend doesnt get the full http payload * dont display http or query params on review

fix: re-configure query param reader

8aa3b3a

hide id reader on review

891a40d

remove unused mosip utils

36cea97

move mosip utils to mosip.ts (#57)

b77f974

move the conditional change from #55 properly with mosip.ts

cc37092

Merge branch 'develop' of github.com:opencrvs/opencrvs-countryconfig-…

018342e

…mosip into fix/query-param-reader-removing-review-params

Merge branch 'develop' of github.com:opencrvs/opencrvs-countryconfig …

0f94087

…into sync-with-countryconfig-develop

Merge pull request #58 from opencrvs/sync-with-countryconfig-develop

ccaf359

Sync with countryconfig develop

Merge branch 'develop' of github.com:opencrvs/opencrvs-countryconfig-…

e8131cc

…mosip into fix/query-param-reader-removing-review-params

fix: update query param reader configuration

77ba894

refactor: configuration so that disable authenticated fields stays di…

4578add

…sabled when review

chore: update toolkit version

e35b5d6

Merge pull request #56 from opencrvs/fix/query-param-reader-removing-…

ddae349

…review-params [OCRVS-10759] Fix query param reader removing review params

bump mosip api to project nid & id type

708574d

connect to fetched nid & id type in rest other pages

f43a106

fix: remove unrelated parent from informants

5d43005

fix: remove parent from idTypes

fec96a5

fix: id reader conditional

2659c5e

Merge pull request #59 from opencrvs/bump-mosip-api-and-project-nid-i…

3ec18d3

…d-type bumps mosip-api to 1.9.0-beta.4 and fetches nid & id type

add NID to birth certificate

e48890e

chore: support qr code pending verificationStatus (#60)

d58fd1c

chore: improve config updates

0a9f775

tahmidrahman-dsi closed this Oct 23, 2025

greptile-apps bot reviewed Oct 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Config update #1114

Config update #1114

Uh oh!

tahmidrahman-dsi commented Oct 23, 2025

Uh oh!

greptile-apps bot left a comment •

edited

Loading

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

greptile-apps bot Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

		- Added Build summary and refactored deployment workflow to be more clear [#6984](https://github.com/opencrvs/opencrvs-core/issues/6984)
		- Build OpenCRVS release images for arm devices [#9455](https://github.com/opencrvs/opencrvs-core/issues/9455)

		## 1.6.4

		- Added a local virtual machine setup for testing Ansible playbooks locally (on MacOS and Ubuntu ). Check [provision.ipynb](infrastructure/local-development/provision.ipynb) for more details.

		const motherID = mother.identifier?.[0].value
		const fatherID = father.identifier?.[0].value

Config update #1114

Config update #1114

Uh oh!

Conversation

tahmidrahman-dsi commented Oct 23, 2025

Description

Checklist

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Additional Comments (1)

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

greptile-apps bot left a comment •

edited

Loading