chore: Sync release-v1.9.0 #1117
Conversation
[OCRVS-10712] Add translation items for flags
Remove all references and configuration to make an environment V2 from country config
Fix multiple bugs in the restore script
Fix metabase pt-2
fix: Moved all common tilt stuff to shared library
Fix age testdata, fix age lookup selectors in birth certificate certified copy
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| - Restricted filesystem usage for journal service and file rotation strategy [#10518](https://github.com/opencrvs/opencrvs-core/issues/10518)) | ||
|
|
||
| - Tiltfile: Improved Kubernetes support for development environment [#10672](https://github.com/opencrvs/opencrvs-core/issues/10672) |
There was a problem hiding this comment.
syntax: Missing space after link number in markdown
| # FIXME: Replace ocrvs-10672 to develop after testing | ||
| git_checkout('[email protected]:opencrvs/infrastructure.git#ocrvs-10672', '../infrastructure') |
There was a problem hiding this comment.
logic: remove FIXME comment and hardcoded branch reference before merging to release. Should this be pointing to 'develop' for the v1.9.0 release, or is ocrvs-10672 the correct branch to use?
| # ------ REINDEX ----- | ||
| ## | ||
| docker run --rm \ | ||
| -v /opt/opencrvs/infrastructure/deployment:/workspace \ |
There was a problem hiding this comment.
logic: The reindex script path is hardcoded to /opt/opencrvs/infrastructure/deployment. This will fail in local environments where ROOT_PATH is different (set to ../opencrvs-core/data on line 75). Consider using $ROOT_PATH/infrastructure/deployment or adding a conditional check for IS_LOCAL. Should the reindex step be skipped in local environments, or should it use a dynamic path based on ROOT_PATH?
| -e 'AUTH_URL=http://auth:4040/' \ | ||
| -e 'EVENTS_URL=http://gateway:7070/events' \ | ||
| alpine \ | ||
| sh -c 'apk add --no-cache curl jq && sh reindex.sh' |
There was a problem hiding this comment.
style: Missing newline at end of file
Note
Currently, we do not run e2e tests as a check on
opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.One method for doing this is to open a PR with these changes to
opencrvs-farajalandas well, and see if the PR check passes there.Description
Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.
Link this pull request to the GitHub issue (and optionally name the branch
ocrvs-<issue #>)Checklist