Skip to content

Conversation

@jamil314
Copy link
Contributor

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

Zangetsu101 and others added 6 commits October 23, 2025 19:38
* fix: save resolved child's country place of birth in analytics db

* fix: add international address

* fix: add missing columns

* fix: Uknown gender

* fix: certification rate

* fix: age group

* fix: order of bars

* fix: label sequence

* fix: lookup country name from object

* fix: completeness rate

* fix: remove await
* fix: add registrationNumber to optimistic action

* fix: update timezone

* fix: metabase filter by event, show only births

* fix: type
fix: Added timeout for snapshot delete action to complete
@github-actions
Copy link
Contributor

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Important Files Changed

File Analysis

Filename Score Overview
infrastructure/backups/backup.sh 4/5 Improved snapshot deletion with individual deletion loop and 30s timeout to prevent race conditions
src/analytics/analytics.ts 5/5 Added country place of birth resolution for analytics with proper fallback to Farajaland
src/index.ts 5/5 Enhanced analytics import to include registration number when action type is REGISTER

5 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@jamil314 jamil314 merged commit 79ff03b into develop Oct 30, 2025
2 checks passed
@jamil314 jamil314 deleted the sync-dev-with-1.9 branch October 30, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants