-
Notifications
You must be signed in to change notification settings - Fork 69
Add readme for analytics #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readme for analytics #1125
Conversation
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| ANALYTICS.md | 3/5 | New comprehensive analytics documentation added. Found TOC mismatch, grammatical error, and unclear wording that need correction. |
| infrastructure/metabase/README.md | 5/5 | Title updated from "OpenCRVS Dashboards" to "OpenCRVS Analytics" for consistency with new documentation. |
2 files reviewed, 3 comments
| - [Architecture](#architecture) | ||
| - [Data Sources](#data-sources) | ||
| - [How Data Flows to Metabase](#how-data-flows-to-metabase) | ||
| - [Available Data in Example Setup](#available-data-in-example-setup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: TOC references non-existent section Available Data in Example Setup - remove from TOC or add the section
| ### Making Dashboard Changes | ||
|
|
||
| 1. **Create/modify dashboards** in development Metabase UI | ||
| 2. **Export the changes** by updating stopping the process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: unclear wording - "by updating stopping the process" should be "by stopping the process"
| 2. **Export the changes** by updating stopping the process | |
| 2. **Export the changes** by stopping the process |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Note
Currently, we do not run e2e tests as a check on
opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.One method for doing this is to open a PR with these changes to
opencrvs-farajalandas well, and see if the PR check passes there.Description
Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.
Link this pull request to the GitHub issue (and optionally name the branch
ocrvs-<issue #>)Checklist