Skip to content

Conversation

@rikukissa
Copy link
Member

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Important Files Changed

File Analysis

Filename Score Overview
ANALYTICS.md 5/5 Added comprehensive analytics documentation covering architecture, data flow, deployment, and development workflows
infrastructure/monitoring/kibana/config.ndjson 5/5 Modified disk space alert to check available bytes (20GB threshold) instead of percentage-based (70%)
src/client-config.js 4/5 Updated dashboard configurations with new IDs, titles, and Metabase URLs; replaced development ping endpoint with analytics dashboards

6 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

description: 'Menu item for registrations dashboard'
},
url: 'http://localhost:3040/ping'
url: `http://localhost:4444/public/dashboard/03be04d6-bde0-4fa7-9141-21cea2a7518b#bordered=false&titled=false&refresh=300` // Filled in below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Remove outdated comment // Filled in below - the URL is already complete and nothing fills it in

@jamil314 jamil314 merged commit 42f5f4a into develop Nov 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants