Skip to content

Conversation

@tareq89
Copy link
Contributor

@tareq89 tareq89 commented Oct 31, 2025

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

issue: opencrvs/opencrvs-core#10907

dedup config for mother was missing the e-signate flow, added mother.verified status.

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@tareq89 tareq89 self-assigned this Oct 31, 2025
@tareq89 tareq89 requested a review from cibelius October 31, 2025 13:40
@github-actions
Copy link
Contributor

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Important Files Changed

File Analysis

Filename Score Overview
src/form/v2/birth/dedupConfig.ts 3/5 Added mother.verified status check for e-signature authentication flow. Potential concern: logic may match two different authenticated mothers as duplicates.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines +28 to +30
field('mother.verified').strictMatches({
value: 'authenticated'
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Verify this logic doesn't cause false positives. strictMatches({ value: 'authenticated' }) returns true when BOTH records have mother.verified === 'authenticated', but this doesn't verify they're the SAME authenticated person. If two different mothers both use e-signature authentication, this condition would match even if their actual IDs differ. Check that when verified === 'authenticated', one of the ID fields (nid/passport/brn) is also populated and would be compared by the earlier OR conditions.

@tareq89
Copy link
Contributor Author

tareq89 commented Nov 3, 2025

Closing since mossip configuration exist in farajaland, not country config!

@tareq89 tareq89 closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants