fix: Revert data collection storage from 30d to 2d #1130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test cases for request correction
chore: add tests for conditionals
# Conflicts: # package.json
Improvements to death certificate pdf tests
# Conflicts: # src/index.ts # yarn.lock
Add testcase for death form date validations
…he page change is not immediate
Fix e2e run reporting on farajaland
Remove all references and configuration to make an environment V2 from country config
Sync develop 21 10 25
…m country config (#1782)
…yconfig into sync-fork-21-10
Sync fork 21 10
fix: e2e for age input
Sync release v1.9.0
chore: add additional test case for declaration action
* add initial mosip interoperability for Farajaland 1.9 * bump mosip api version * use new version for mosip repo * upgrade toolkit * add verification status for mother * update env variables as documented * update the translation to be more realistic description todo still * update description translation * move mosip interop url to be changeable with env vars * add verification for father and informant * fix failed translations * fix typo with mutating declaration instead of updatedFields * add deceased verification * update toolkit according to core * update text to status as per toolkit new version * add nid field for child * bump mosip package * add NID to birth certificate * fix aggregate not needing 2nd param anymore * chore: restore mosip fields in v2 form * update mosip api to 1.9.0-beta.4 * sync with latest form changes * remove old mosip api references * bump to beta.6 * bump mosip api version * fix ui not waiting for external validation in e2es * fix: 4.5.2, 3.7.2 * fix: function name typo * ensure external validation is empty in 1.4.2 2.2.6 5.5 * ensure external validation is empty in 8.3.8 * chore: disable 2FA on v19-beta-prod This reverts commit e65363c. * chore: enable 2FA on v19-beta-prod This reverts commit b85245f. * try if ensuring external validation fixes form state test * align farajaland custom-event/handler with countryconfig-mosip * fix: remove registrationNumber validation for external ID providers When an external ID provider (e.g., MOSIP) is integrated, the registrationNumber may not be immediately available after a registration is submitted.By the time the script logs in and navigates to the record audit view, the registrationNumber might already exist in the UI, but it’s not reliably accessible as a reference value in this context. Removing the strict check ensures smoother flow and avoids false negatives in such cases. * copy mosip.ts properly over from opencrvs-countryconfig-mosip * fix(correction-summary): remove registrationNumber validation for external ID providers When an external ID provider (e.g., MOSIP) is integrated, the registrationNumber may not be immediately available after a registration is submitted.By the time the script logs in and navigates to the record audit view, the registrationNumber might already exist in the UI, but it’s not reliably accessible as a reference value in this context. Removing the strict check ensures smoother flow and avoids false negatives in such cases. --------- Co-authored-by: Md. Ashikul Alam <[email protected]> Co-authored-by: Md. Ashikul Alam <[email protected]> Co-authored-by: tahmidrahman-dsi <[email protected]> Co-authored-by: jamil314 <[email protected]>
This comment has been minimized.
This comment has been minimized.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Overview
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| infrastructure/monitoring/metricbeat/metricbeat-rollover-policy.json | 4/5 | Reverts data retention from 30d to 2d and simplifies ILM policy phases; metadata description needs updating to reflect 2d retention |
Additional Comments (1)
-
infrastructure/monitoring/metricbeat/metricbeat-rollover-policy.json, line 24 (link)syntax: description still references "7 days" but policy is now 2 days
1 file reviewed, 1 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Currently, we do not run e2e tests as a check on
opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.One method for doing this is to open a PR with these changes to
opencrvs-farajalandas well, and see if the PR check passes there.Description
Goal of this PR is to revert changes introduced by #1039
Checklist