Skip to content

Conversation

@adskyiproger
Copy link
Contributor

@adskyiproger adskyiproger commented Nov 3, 2025

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

Goal of this PR is to revert changes introduced by #1039

Testing

Usage reported before fix deployment:

jamil@farajaland-dev:/data$ sudo du -h --max-depth=1 | sort -rh
48G	.
41G	./elasticsearch
674M	./mongo
185M	./minio
100M	./influxdb
71M	./postgres
140K	./traefik
32K	./vsexport
32K	./backups
28K	./sqlite
16K	./lost+found
8.0K	./secrets
4.0K	./wireguard

Deployment: https://github.com/opencrvs/opencrvs-farajaland/actions/runs/19032563850/job/54349792255

Verified usage after depoyment:
image

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Important Files Changed

File Analysis

Filename Score Overview
infrastructure/monitoring/metricbeat/metricbeat-rollover-policy.json 4/5 Reverts Elasticsearch ILM policy from 30d (hot/warm/cold/delete) to 2d (hot/delete), with stale _meta.description mentioning "7 days"

Additional Comments (1)

  1. infrastructure/monitoring/metricbeat/metricbeat-rollover-policy.json, line 24 (link)

    syntax: description says "retention of 7 days" but policy deletes at 2d

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@adskyiproger adskyiproger merged commit 024a5ac into release-v1.9.0 Nov 3, 2025
6 checks passed
@adskyiproger adskyiproger deleted the fix-metricbeat branch November 3, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants