feat: Verify passphrase before provision new one #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This comment has been minimized.
This comment has been minimized.
adskyiproger
force-pushed
the
ocrvs-10896-validate
branch
3 times, most recently
from
bf9fc58 to
59f0ced
Compare
adskyiproger
commented
Nov 5, 2025
| @@ -1,4 +1,38 @@ | |||
| - name: Save disk encryption key into a file as an example (in production use a hardware security module) | |||
| - name: Ensure 'cryptsetup' utility is installed | |||
Contributor
Author
There was a problem hiding this comment.
Nice to have this check
| - data-partition | ||
|
|
||
| - include_tasks: | ||
| file: tasks/validate-data-partition.yml |
Contributor
Author
There was a problem hiding this comment.
This validation step should be executed for data-partition and for decrypt-on-boot
adskyiproger
force-pushed
the
ocrvs-10896-validate
branch
from
59f0ced to
71bd224
Compare
cibelius
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Currently, we do not run e2e tests as a check on
opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.One method for doing this is to open a PR with these changes to
opencrvs-farajalandas well, and see if the PR check passes there.Description
This PR aims to address an issue: opencrvs/opencrvs-core#10896
See more test results at: opencrvs/infrastructure#157
Testing Farajaland
Successful provision
https://github.com/opencrvs/opencrvs-farajaland/actions/runs/19103153498/job/54579952977
Failure example
https://github.com/opencrvs/opencrvs-farajaland/actions/runs/19103449788/job/54580946988
Password was modified on disk
https://github.com/opencrvs/opencrvs-farajaland/actions/runs/19104776971/job/54585564136
Checklist