Update declaration payload to match FieldValue
#1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
5 tasks
Zangetsu101
approved these changes
Nov 13, 2025
Contributor
Zangetsu101
left a comment
Zangetsu101
left a comment
There was a problem hiding this comment.
Let's take another look at the address values, the others look fine
| country: 'FAR', | ||
| addressType: 'DOMESTIC', | ||
| province: '05cbe3a1-9020-47bd-b558-807607c2f119', | ||
| district: 'afaead2b-7ef5-4adb-b4bf-3d2b8437c284', |
Contributor
There was a problem hiding this comment.
Shouldn't the equivalent for this be administrativeAread: 'afaead2b-7ef5-4adb-b4bf-3d2b8437c284'
Siyasanga
pushed a commit
that referenced
this pull request
Dec 8, 2025
* fix: Missed conditions on key * Update declaration payload to match `FieldValue` (#1138) * update toolkit * fix: update test data * fix: update toolkit * update toolkit * update toolkit(#a29215b) * fix: add admin area in test data address * Upgrade traefik to 2.11 Fixed Docker API version issue --------- Co-authored-by: Vadym Mudryi <[email protected]> Co-authored-by: Md. Ashikul Alam <[email protected]> Co-authored-by: Barry Dwyer <[email protected]> Co-authored-by: Barry Dwyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Currently, we do not run e2e tests as a check on
opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.One method for doing this is to open a PR with these changes to
opencrvs-farajalandas well, and see if the PR check passes there.Description
Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.
Link this pull request to the GitHub issue (and optionally name the branch
ocrvs-<issue #>)Checklist