Skip to content

Conversation

@adskyiproger
Copy link
Contributor

Note

Currently, we do not run e2e tests as a check on opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.

One method for doing this is to open a PR with these changes to opencrvs-farajaland as well, and see if the PR check passes there.

Description

Goal of this PR is to implement restriction on git branch names: opencrvs/opencrvs-core#9816

Branch name is limited to 30 characters due to helm release name limitations 53 characters.

NOTE: 30 characters length is the restriction increased a while ago for docker (moby/moby#11118)

Related PR: opencrvs/infrastructure#187

Screenshare.-.2025-11-21.5_11_45.PM.mp4

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link
Contributor

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@adskyiproger adskyiproger changed the title Add husky Add husky pre-push hooks Nov 24, 2025
@adskyiproger adskyiproger merged commit 4c35da1 into develop Nov 24, 2025
2 checks passed
@adskyiproger adskyiproger deleted the add-husky branch November 24, 2025 09:12
@cibelius cibelius mentioned this pull request Nov 24, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants