feat: Build assets for vanilla metabase image #1162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Currently, we do not run e2e tests as a check on
opencrvs-countryconfig-repo PRs. Please ensure your PR doesn't break any e2e tests.One method for doing this is to open a PR with these changes to
opencrvs-farajalandas well, and see if the PR check passes there.Description
This PR aims to address issue opencrvs/opencrvs-core#11146
Preconditions:
metabase.init.db.sqlwhich is used for metabase configurationIdea:
How it works?
-assetsSee related PR with infrastructure changes: opencrvs/infrastructure#195
!!! This PR contains tricky code !!!
This is not best practice to create 2 docker images within the same repository, from different base images.
Image build produce 2 artifacts, e/g:
ocrvs-countryconfig:e359075: country configocrvs-countryconfig:e359075-assets: Metabase assetsIn general best practice says we need to setup 2 repositories, but DockerHub has support only for one no-cost private repository.
Checklist