Skip to content

Conversation

@naftis
Copy link
Member

@naftis naftis commented Sep 24, 2024

opencrvs/opencrvs-core#5932

Refactors country-config to use envalid and enforce setting environment variables in production.

@naftis naftis added this to the v1.7.0 milestone Sep 24, 2024
@github-actions
Copy link
Contributor

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis naftis requested a review from rikukissa November 6, 2024 09:31
@naftis naftis force-pushed the ocrvs-5932-country-config branch from ca23885 to 58762cd Compare November 6, 2024 09:33
@naftis naftis requested review from tahmidrahman-dsi and removed request for rikukissa November 6, 2024 09:34
Copy link
Contributor

@tahmidrahman-dsi tahmidrahman-dsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Seems a change needed in one of the unchanged files to pass ts compile check

@tahmidrahman-dsi tahmidrahman-dsi merged commit 7741fb1 into develop Nov 6, 2024
2 checks passed
@naftis naftis deleted the ocrvs-5932-country-config branch November 6, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants