print birth certificate action added #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
tareq89
force-pushed
the
v2-print-birth-certificate
branch
from
a08c899 to
820df82
Compare
makelicious
reviewed
Mar 12, 2025
makelicious
approved these changes
Mar 12, 2025
Contributor
makelicious
left a comment
makelicious
left a comment
There was a problem hiding this comment.
Good stuff. Final cleanup and we are good to go.
| conditionals: [ | ||
| { | ||
| type: ConditionalType.SHOW, | ||
| conditional: field('collector.requesterId').isEqualTo('OTHER') |
Contributor
There was a problem hiding this comment.
Could you use CertCollectorType.OTHER here, too? The benefit is that we do not need to worry about typos
…into v2-print-birth-certificate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/opencrvs/opencrvs-core/compare/v2-print-birth-certificate?expand=1