National ID validation, informant/mother/father DOB not after child validation #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
4 tasks
cibelius
changed the title
makelicious
approved these changes
Apr 4, 2025
Contributor
makelicious
left a comment
makelicious
left a comment
There was a problem hiding this comment.
Very nice, check the translations with riku
| { | ||
| message: { | ||
| defaultMessage: 'Must be a valid Birthdate', | ||
| defaultMessage: 'Must be a valid birth date', |
Contributor
There was a problem hiding this comment.
I think it was intentionally change to the format QA requires. @rikukissa
Contributor
Author
There was a problem hiding this comment.
The new one matches V1, so should be ok 👍 capitalised "Birthdate" also sounds weird, probably more of an issue on the QA requirements
| v2.event.birth.action.declare.form.section.child.field.birthLocation.label,This is the label for the field,Location of birth,Lieu de naissance | ||
| v2.event.birth.action.declare.form.section.child.field.birthType.label,This is the label for the field,Type of birth,Type d'accouchement | ||
| v2.event.birth.action.declare.form.section.child.field.dob.error,This is the error message for invalid date,Please enter a valid date,Please enter a valid date | ||
| v2.event.birth.action.declare.form.section.child.field.dob.error,This is the error message for invalid date,Must be a valid birth date,Doit être une date de naissance valide |
Contributor
There was a problem hiding this comment.
Improvements. @rikukissa do we want to stick with exact same phrases
This was referenced May 2, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 5, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 29, 2025
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opencrvs/opencrvs-core#8905 & opencrvs/opencrvs-core#8917
Core PR: opencrvs/opencrvs-core#9118
Checklist