Skip to content

fix: navigation e2es #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jamil314 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: navigation e2es #1825

jamil314 wants to merge 4 commits into from

Conversation

@jamil314
Copy link

@jamil314 jamil314 commented Nov 13, 2025

Description

Used the e2e files from v2.0-tmp

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@jamil314 jamil314 requested a review from cibelius November 13, 2025 13:11
cibelius
cibelius reviewed Nov 13, 2025
View reviewed changes
e2e/testcases/navigation/navigating-in-and-out-of-action.spec.ts
await expect(page.locator('#content-name')).toContainText('Ready to print')
})

test('Browser forward button should take user back to the event overview page', async () => {
Copy link

@cibelius cibelius Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this text correct anymore?

This was referenced Nov 14, 2025
Merged
Merged
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cibelius cibelius cibelius approved these changes

@rikukissa rikukissa rikukissa approved these changes

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamil314 @rikukissa @cibelius