Fix: time series data request exceeding limit - #6
Open
lim-yoona wants to merge 2 commits into
Open
Conversation
Author
|
Add incoming parameters: func QueryRangeMetric(name string, start, end, interval uint64, results *chan MetricResult) {}or getting the time information from the name parameter: nameSlice := strings.Split(name,"&")
str := nameSlice[0]
start := nameSlice[1][6:]
end := nameSlice[2][4:]
interval := nameSlice[3][5:]Then use strconv to convert the string to uint64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I implemented the logic of multiple requests in the QueryRangeMetric function of internal/metrics/common/common.go. I think it is more complicated to get the time information from the name parameter, so I need to pass in three parameters: start, end and interval. This results in many calls to this function needing to be modified, so there are more changes.
If it feels inappropriate, I will modify the code again.
Related issue
#3