Skip to content

Fix: time series data request exceeding limit - #6

Open
lim-yoona wants to merge 2 commits into
opencurve:masterfrom
lim-yoona:fix/time_series_data_request_exceeding_limit
Open

Fix: time series data request exceeding limit#6
lim-yoona wants to merge 2 commits into
opencurve:masterfrom
lim-yoona:fix/time_series_data_request_exceeding_limit

Conversation

@lim-yoona

Copy link
Copy Markdown

Description

I implemented the logic of multiple requests in the QueryRangeMetric function of internal/metrics/common/common.go. I think it is more complicated to get the time information from the name parameter, so I need to pass in three parameters: start, end and interval. This results in many calls to this function needing to be modified, so there are more changes.

If it feels inappropriate, I will modify the code again.

Related issue

#3

@lim-yoona

lim-yoona commented Oct 10, 2023

Copy link
Copy Markdown
Author

Add incoming parameters:

func QueryRangeMetric(name string, start, end, interval uint64, results *chan MetricResult) {}

or getting the time information from the name parameter:

nameSlice := strings.Split(name,"&")
str := nameSlice[0]
start := nameSlice[1][6:]
end := nameSlice[2][4:]
interval := nameSlice[3][5:]

Then use strconv to convert the string to uint64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant