Skip to content

Parse NCI filepaths to THREDDS location#523

Open
Ariana-B wants to merge 9 commits into
developfrom
nci_links
Open

Parse NCI filepaths to THREDDS location#523
Ariana-B wants to merge 9 commits into
developfrom
nci_links

Conversation

@Ariana-B

@Ariana-B Ariana-B commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

As per #520


📚 Documentation preview 📚: https://datacube-explorer--523.org.readthedocs.build/en/523/

@Ariana-B Ariana-B requested review from dunkgray and jmettes March 3, 2023 05:25
@Ariana-B Ariana-B linked an issue Mar 3, 2023 that may be closed by this pull request

@dunkgray dunkgray left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, though I haven't worked on this code.

@omad omad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ariana,

Can you please make this an opt-in/configurable option. Explorer isn't only used by DEA, and this change would be most unexpected in other environments. :)

Cheers

@codecov

codecov Bot commented Mar 6, 2023

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.24%. Comparing base (aa0d9f3) to head (358fe01).
Report is 4 commits behind head on develop.

❗ Current head 358fe01 differs from pull request most recent head d6ffbd7. Consider uploading reports for the commit d6ffbd7 to get more accurate results

Files Patch % Lines
cubedash/_utils.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #523      +/-   ##
===========================================
- Coverage    86.29%   86.24%   -0.05%     
===========================================
  Files           26       26              
  Lines         3451     3461      +10     
===========================================
+ Hits          2978     2985       +7     
- Misses         473      476       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpaget

mpaget commented Mar 18, 2023

Copy link
Copy Markdown
Contributor

an opt-in/configurable option

Yes, I expect this would be good to have configurable by a deployment admin. Sharing some ideas, if helpful.

If URL converting regexs or functions were imported from settings.env.py we'd need to consider the security implications and do some careful vetting. I'm not sure of the effort or appetite to look at it from that perspective. A transparent in-code solution would be easier.

As a deployment patch perhaps? Perhaps settings.env.py could reference an as_external_url function that can be imported by explorer, else the "s3" default is used. The custom as_external_url function would need to be uploaded to the host running explorer. This may require an update to the explorer chart too.

@whatnick

whatnick commented Apr 1, 2023

Copy link
Copy Markdown
Member

Could we please update this to latest develop to avoid potential merge with rebase issues, especially if global settings are being changed. This will affect the main file where the timezone setting was recently added.

@Ariana-B Ariana-B marked this pull request as ready for review May 19, 2023 05:43
@Ariana-B Ariana-B requested a review from omad March 5, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NCI local filesystem indexed thumbnails are inaccessible from web

5 participants