Fix some grid_spec warnings#658
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #658 +/- ##
===========================================
+ Coverage 89.26% 89.57% +0.30%
===========================================
Files 34 34
Lines 4119 4229 +110
===========================================
+ Hits 3677 3788 +111
+ Misses 442 441 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
0ae3cc4 to
b691b3d
Compare
|
This fixes 550 warnings that After this PR, it's clear that the remaining GridSpec warnings are caused by |
Make a private function that extracts the same product information that was previously gotten from the now deprecated grid_spec, and then use that helper instead of grid_spec. The helper should be removed once there are suitable replacements in some part of the opendatacube-API.
b691b3d to
fc05481
Compare
|
Making this a draft since opendatacube/datacube-core#1783 revealed the resolution can be a scalar. If the grid_spec property remains and is no longer deprecated, I think it would be better to use that than replicate the same functionality in explorer. |
Make a private function that
extracts the same product information
that was previously gotten from
the now deprecated grid_spec,
and then use that helper instead
of grid_spec.
The helper should be removed once
there are suitable replacements
in some part of the opendatacube-API.
📚 Documentation preview 📚: https://datacube-explorer--658.org.readthedocs.build/en/658/